From: Jakub Jelinek <jakub@redhat.com>
Date: Fri, 20 Dec 2019 23:18:09 +0000 (+0100)
Subject: re PR c++/92973 (Silently accepting defaulted comparison operators in C++11 .. 17)
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=8aca5ebe07efd6d710c76eff2d3524f6c5c4ff2b;p=gcc.git

re PR c++/92973 (Silently accepting defaulted comparison operators in C++11 .. 17)

	PR c++/92973
	* method.c (early_check_defaulted_comparison): For C++17 and earlier
	diagnose defaulted comparison operators.

	* g++.dg/cpp0x/spaceship-eq1.C: New test.

From-SVN: r279682
---

diff --git a/gcc/cp/ChangeLog b/gcc/cp/ChangeLog
index 5a9a648d333..07200ad21e5 100644
--- a/gcc/cp/ChangeLog
+++ b/gcc/cp/ChangeLog
@@ -1,5 +1,9 @@
 2019-12-20  Jakub Jelinek  <jakub@redhat.com>
 
+	PR c++/92973
+	* method.c (early_check_defaulted_comparison): For C++17 and earlier
+	diagnose defaulted comparison operators.
+
 	PR c++/92666
 	* call.c (convert_arg_to_ellipsis): For floating point or
 	decltype(nullptr) arguments call mark_rvalue_use.
diff --git a/gcc/cp/method.c b/gcc/cp/method.c
index 97c27c51ea3..248a0e55f06 100644
--- a/gcc/cp/method.c
+++ b/gcc/cp/method.c
@@ -1092,6 +1092,13 @@ early_check_defaulted_comparison (tree fn)
     ctx = DECL_FRIEND_CONTEXT (fn);
   bool ok = true;
 
+  if (cxx_dialect < cxx2a)
+    {
+      error_at (loc, "defaulted %qD only available with %<-std=c++2a%> or "
+		     "%<-std=gnu++2a%>", fn);
+      return false;
+    }
+
   if (!DECL_OVERLOADED_OPERATOR_IS (fn, SPACESHIP_EXPR)
       && !same_type_p (TREE_TYPE (TREE_TYPE (fn)), boolean_type_node))
     {
diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index dd9e529ebca..40568bb98be 100644
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,5 +1,8 @@
 2019-12-20  Jakub Jelinek  <jakub@redhat.com>
 
+	PR c++/92973
+	* g++.dg/cpp0x/spaceship-eq1.C: New test.
+
 	PR c++/92666
 	* g++.dg/warn/Wunused-var-36.C: New test.
 
diff --git a/gcc/testsuite/g++.dg/cpp0x/spaceship-eq1.C b/gcc/testsuite/g++.dg/cpp0x/spaceship-eq1.C
new file mode 100644
index 00000000000..2e0ad0c53f7
--- /dev/null
+++ b/gcc/testsuite/g++.dg/cpp0x/spaceship-eq1.C
@@ -0,0 +1,5 @@
+// PR c++/92973
+// { dg-do compile { target c++11 } }
+
+struct S { bool operator==(const S&) const = default; int s; };	// { dg-error "only available with" "" { target c++17_down } }
+struct T { bool operator!=(const T&) const = default; int t; };	// { dg-error "only available with" "" { target c++17_down } }