From: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Date: Fri, 24 Jan 2020 21:45:41 +0000 (+0200)
Subject: isl: add gen12 comment about CCS for linear tiling
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=8bd92a15cf28714f1752fbdbafcf78f575e16f13;p=mesa.git

isl: add gen12 comment about CCS for linear tiling

Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Jason Ekstrand <jason@jlekstrand.net>
Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3551>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3551>
---

diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c
index d68ac324d07..f737f8b3b53 100644
--- a/src/intel/isl/isl.c
+++ b/src/intel/isl/isl.c
@@ -2020,6 +2020,16 @@ isl_surf_get_ccs_surf(const struct isl_device *dev,
       if (surf->tiling != ISL_TILING_Y0)
          return false;
 
+      /* BSpec 44930:
+       *
+       *    Linear CCS is only allowed for Untyped Buffers but only via HDC
+       *    Data-Port messages.
+       *
+       * We probably want to limit linear CCS to storage usage and check that
+       * the shaders actually use only untyped messages.
+       */
+      assert(surf->tiling != ISL_TILING_LINEAR);
+
       switch (isl_format_get_layout(surf->format)->bpb) {
       case 8:     ccs_format = ISL_FORMAT_GEN12_CCS_8BPP_Y0;    break;
       case 16:    ccs_format = ISL_FORMAT_GEN12_CCS_16BPP_Y0;   break;