From: Giacomo Travaglini <giacomo.travaglini@arm.com>
Date: Fri, 15 May 2020 09:31:51 +0000 (+0100)
Subject: tests: log_call is not returning any value
X-Git-Tag: v20.1.0.0~580
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=8c0d063e37757f9aca591c116da6747382abe938;p=gem5.git

tests: log_call is not returning any value

JIRA: https://gem5.atlassian.net/projects/GEM5/issues/GEM5-533

Change-Id: I2713ddacc762d614e3992718ea234287d06c179a
Signed-off-by: Giacomo Travaglini <giacomo.travaglini@arm.com>
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/30214
Maintainer: Bobby R. Bruce <bbruce@ucdavis.edu>
Tested-by: kokoro <noreply+kokoro@google.com>
Reviewed-by: Hoa Nguyen <hoanguyen@ucdavis.edu>
---

diff --git a/tests/gem5/suite.py b/tests/gem5/suite.py
index 4cf0f81a2..329e31fc7 100644
--- a/tests/gem5/suite.py
+++ b/tests/gem5/suite.py
@@ -178,7 +178,6 @@ def _create_test_run_gem5(config, config_args, gem5_args):
         # I.E. Only the returncode verifier will use the gem5_returncode
         # fixture, but we always require it even if that verifier isn't being
         # ran.
-        returncode = fixtures[constants.gem5_returncode_fixture_name]
         tempdir = fixtures[constants.tempdir_fixture_name].path
         gem5 = fixtures[constants.gem5_binary_fixture_name].path
         command = [
@@ -191,7 +190,6 @@ def _create_test_run_gem5(config, config_args, gem5_args):
         command.append(config)
         # Config_args should set up the program args.
         command.extend(config_args)
-        returncode.value = log_call(params.log, command, stdout=sys.stdout,
-                                                         stderr=sys.stderr)
+        log_call(params.log, command, stdout=sys.stdout, stderr=sys.stderr)
 
     return test_run_gem5