From: Kevin Lim <ktlim@umich.edu>
Date: Thu, 6 Jul 2006 17:57:21 +0000 (-0400)
Subject: Change the return value of drain.  False means the object wasn't able to drain yet.
X-Git-Tag: m5_2.0_beta1~36^2~20^2~1
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=8c547d80b1a091f41f5516f58ad7368181fe4041;p=gem5.git

Change the return value of drain.  False means the object wasn't able to drain yet.

src/python/m5/config.py:
    Invert the return value.
src/sim/sim_object.cc:
    Invert the return value of drain.
src/sim/sim_object.hh:
    Change the return value of drain.

--HG--
extra : convert_revision : 41bb122c6f29302d8b3815d7bd6a2ea8fba64df9
---

diff --git a/src/python/m5/config.py b/src/python/m5/config.py
index cffe06984..8291e1e1b 100644
--- a/src/python/m5/config.py
+++ b/src/python/m5/config.py
@@ -547,7 +547,7 @@ class SimObject(object):
         count = 0
         # ParamContexts don't serialize
         if isinstance(self, SimObject) and not isinstance(self, ParamContext):
-            if self._ccObject.drain(drain_event):
+            if not self._ccObject.drain(drain_event):
                 count = 1
         if recursive:
             for child in self._children.itervalues():
diff --git a/src/sim/sim_object.cc b/src/sim/sim_object.cc
index 655bdcf4e..a0278dba0 100644
--- a/src/sim/sim_object.cc
+++ b/src/sim/sim_object.cc
@@ -277,7 +277,7 @@ SimObject::drain(Event *drain_event)
               "in timing mode!");
     }
     state = DrainedAtomic;
-    return false;
+    return true;
 }
 
 void
diff --git a/src/sim/sim_object.hh b/src/sim/sim_object.hh
index 4833192d6..7ecc00958 100644
--- a/src/sim/sim_object.hh
+++ b/src/sim/sim_object.hh
@@ -116,7 +116,7 @@ class SimObject : public Serializable, protected StartupCallback
 
     // Methods to drain objects in order to take checkpoints
     // Or switch from timing -> atomic memory model
-    // Quiesce returns true if the SimObject cannot quiesce immediately.
+    // Drain returns false if the SimObject cannot drain immediately.
     virtual bool drain(Event *drain_event);
     virtual void resume();
     virtual void setMemoryMode(State new_mode);