From: Alan Modra <amodra@gmail.com>
Date: Sun, 29 Dec 2019 02:26:29 +0000 (+1030)
Subject: Usage of unitialized heap in tic4x_print_cond
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=8c5e259235a4e4546910245b170de1e29a711034;p=binutils-gdb.git

Usage of unitialized heap in tic4x_print_cond

	PR 25319
	* tic4x-dis.c (tic4x_print_cond): Init all of condtable.
---

diff --git a/opcodes/ChangeLog b/opcodes/ChangeLog
index 9a151230427..5187fb21769 100644
--- a/opcodes/ChangeLog
+++ b/opcodes/ChangeLog
@@ -1,3 +1,8 @@
+2019-12-29  Alan Modra  <amodra@gmail.com>
+
+	PR 25319
+	* tic4x-dis.c (tic4x_print_cond): Init all of condtable.
+
 2019-12-27  Jan Beulich  <jbeulich@suse.com>
 
 	* i386-dis.c (Jdqw): Define.
diff --git a/opcodes/tic4x-dis.c b/opcodes/tic4x-dis.c
index d9f95c94106..01cfa1e060f 100644
--- a/opcodes/tic4x-dis.c
+++ b/opcodes/tic4x-dis.c
@@ -277,7 +277,7 @@ tic4x_print_cond (struct disassemble_info *info, unsigned int cond)
 
   if (condtable == NULL)
     {
-      condtable = xmalloc (sizeof (tic4x_cond_t *) * 32);
+      condtable = xcalloc (sizeof (tic4x_cond_t *), 32);
       for (i = 0; i < tic4x_num_conds; i++)
 	condtable[tic4x_conds[i].cond] = (tic4x_cond_t *)(tic4x_conds + i);
     }