From: Steven G. Kargl <kargl@gcc.gnu.org>
Date: Thu, 10 Jan 2019 01:11:51 +0000 (+0000)
Subject: re PR fortran/88376 (ICE in is_illegal_recursion, at fortran/resolve.c:1689)
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=8c94b8dad232c35a3d713c5df782e90ee560985f;p=gcc.git

re PR fortran/88376 (ICE in is_illegal_recursion, at fortran/resolve.c:1689)

2019-01-09  Steven G. Kargl  <kargl@gcc.gnu.org>

	PR fortran/88376
	* resolve.c (is_illegal_recursion): Remove an assert().

2019-01-09  Steven G. Kargl  <kargl@gcc.gnu.org>

	PR fortran/88376
	* gfortran.dg/pr88376.f90: New test.

From-SVN: r267793
---

diff --git a/gcc/fortran/ChangeLog b/gcc/fortran/ChangeLog
index 9a030c81656..d96f2c1ff2e 100644
--- a/gcc/fortran/ChangeLog
+++ b/gcc/fortran/ChangeLog
@@ -1,13 +1,16 @@
+2019-01-09  Steven G. Kargl  <kargl@gcc.gnu.org>
+
+	PR fortran/88376
+	* resolve.c (is_illegal_recursion): Remove an assert().
+
 2019-01-09  Sandra Loosemore  <sandra@codesourcery.com>
 
 	PR other/16615
-
 	* expr.c: Change "can not" to "cannot".
 
 2019-01-09  Sandra Loosemore  <sandra@codesourcery.com>
 
 	PR other/16615
-
 	* class.c: Mechanically replace "can not" with "cannot".
 	* decl.c: Likewise.
 	* expr.c: Likewise.
diff --git a/gcc/fortran/resolve.c b/gcc/fortran/resolve.c
index a681ecaf249..d18f2d8aefa 100644
--- a/gcc/fortran/resolve.c
+++ b/gcc/fortran/resolve.c
@@ -1686,8 +1686,6 @@ is_illegal_recursion (gfc_symbol* sym, gfc_namespace* context)
       || gfc_fl_struct (sym->attr.flavor))
     return false;
 
-  gcc_assert (sym->attr.flavor == FL_PROCEDURE);
-
   /* If we've got an ENTRY, find real procedure.  */
   if (sym->attr.entry && sym->ns->entries)
     proc_sym = sym->ns->entries->sym;
diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index fc8395f76f6..a1786d101f5 100644
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,7 +1,11 @@
+2019-01-09  Steven G. Kargl  <kargl@gcc.gnu.org>
+
+	PR fortran/88376
+	* gfortran.dg/pr88376.f90: New test.
+
 2019-01-09  Sandra Loosemore  <sandra@codesourcery.com>
 
 	PR other/16615
-
 	* g++.dg/lto/odr-1_1.C: Update diagnostic message patterns to replace
 	"can not" with "cannot".
 	* gfortran.dg/common_15.f90: Likewise.
diff --git a/gcc/testsuite/gfortran.dg/pr88376.f90 b/gcc/testsuite/gfortran.dg/pr88376.f90
new file mode 100644
index 00000000000..5dd0181b09b
--- /dev/null
+++ b/gcc/testsuite/gfortran.dg/pr88376.f90
@@ -0,0 +1,8 @@
+! { dg-do compile }
+module m
+   integer :: n
+contains
+   subroutine s
+      character(n(3)) :: c  ! { dg-error "not a function" }
+   end
+end