From: Chris Wilson Date: Fri, 30 Sep 2011 20:48:18 +0000 (+0100) Subject: i965/gen6: Fix assign instead of compare in assert X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=8ccbcda5c64a8bea47f6b41d46bf015ba8e515fc;p=mesa.git i965/gen6: Fix assign instead of compare in assert This is from a Coverity defect report. src/mesa/drivers/dri/i965/brw_vec4_emit.cpp 268 static void 269 check_gen6_math_src_arg(struct brw_reg src) 270 { 271 /* Source swizzles are ignored. */ 272 assert(!src.abs); 273 assert(!src.negate); -> 274 assert(src.dw1.bits.swizzle = BRW_SWIZZLE_XYZW); 275 } Reported-by: Vinson Lee Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=40214 Signed-off-by: Chris Wilson --- diff --git a/src/mesa/drivers/dri/i965/brw_vec4_emit.cpp b/src/mesa/drivers/dri/i965/brw_vec4_emit.cpp index 1eb8f3f78a3..3feecbf805d 100644 --- a/src/mesa/drivers/dri/i965/brw_vec4_emit.cpp +++ b/src/mesa/drivers/dri/i965/brw_vec4_emit.cpp @@ -257,7 +257,7 @@ check_gen6_math_src_arg(struct brw_reg src) /* Source swizzles are ignored. */ assert(!src.abs); assert(!src.negate); - assert(src.dw1.bits.swizzle = BRW_SWIZZLE_XYZW); + assert(src.dw1.bits.swizzle == BRW_SWIZZLE_XYZW); } void