From: Rob Clark Date: Mon, 27 Jan 2020 16:26:04 +0000 (-0800) Subject: freedreno/ir3: create fragcoord instructions in input block X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=8d0e7d9a4c1cfe28b3cd2356e94e287e82821e1a;p=mesa.git freedreno/ir3: create fragcoord instructions in input block This was somehow working to create the instructions in a random block, and use the value in other blocks, by dumb luck. But two-pass-RA's better choice of register assignment causes a couple dEQPs to start failing without this fix: dEQP-GLES3.functional.shaders.metamorphic.bubblesort_flag.variant_1 dEQP-GLES3.functional.shaders.metamorphic.bubblesort_flag.variant_2 Signed-off-by: Rob Clark Part-of: --- diff --git a/src/freedreno/ir3/ir3_compiler_nir.c b/src/freedreno/ir3/ir3_compiler_nir.c index a7536cfecd2..747b66ac58a 100644 --- a/src/freedreno/ir3/ir3_compiler_nir.c +++ b/src/freedreno/ir3/ir3_compiler_nir.c @@ -1306,12 +1306,12 @@ static struct ir3_instruction * get_frag_coord(struct ir3_context *ctx) { if (!ctx->frag_coord) { - struct ir3_block *b = ctx->block; + struct ir3_block *b = ctx->in_block; struct ir3_instruction *xyzw[4]; struct ir3_instruction *hw_frag_coord; hw_frag_coord = create_sysval_input(ctx, SYSTEM_VALUE_FRAG_COORD, 0xf); - ir3_split_dest(ctx->block, xyzw, hw_frag_coord, 0, 4); + ir3_split_dest(b, xyzw, hw_frag_coord, 0, 4); /* for frag_coord.xy, we get unsigned values.. we need * to subtract (integer) 8 and divide by 16 (right-