From: Eric Engestrom <eric.engestrom@intel.com>
Date: Mon, 23 Sep 2019 16:21:20 +0000 (+0100)
Subject: meson: add -Werror=empty-body to disallow `if(x);`
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=8d43e2b2ded0fe3c82d49561cdab9f208f9e64b6;p=mesa.git

meson: add -Werror=empty-body to disallow `if(x);`

This would have prevented a bug in MR 2058 [1]; with that MR fixed,
nothing else uses empty-body blocks, so let's just forbid them altogether.

[1] https://gitlab.freedesktop.org/mesa/mesa/merge_requests/2058#note_237880

Signed-off-by: Eric Engestrom <eric.engestrom@intel.com>
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
Reviewed-by: Kristian H. Kristensen <hoegsberg@google.com>
---

diff --git a/meson.build b/meson.build
index b4cd7999566..ac864819013 100644
--- a/meson.build
+++ b/meson.build
@@ -939,6 +939,7 @@ else
     '-Werror=implicit-function-declaration',
     '-Werror=missing-prototypes',
     '-Werror=return-type',
+    '-Werror=empty-body',
     '-Werror=incompatible-pointer-types',
     '-Wno-missing-field-initializers',
     '-Wno-format-truncation',
@@ -958,6 +959,7 @@ else
 
   _trial = [
     '-Werror=return-type',
+    '-Werror=empty-body',
     '-Wno-non-virtual-dtor',
     '-Wno-missing-field-initializers',
     '-Wno-format-truncation',