From: Alan Modra <amodra@gmail.com>
Date: Tue, 16 Oct 2018 04:53:20 +0000 (+1030)
Subject: PR23781, _bfd_pe_bfd_copy_private_bfd_data_common memory leak
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=8df73d5cc3a87101f3bd254f33820fcce61bc971;p=binutils-gdb.git

PR23781, _bfd_pe_bfd_copy_private_bfd_data_common memory leak

	PR 23781
	* peXXigen.c (_bfd_XX_bfd_copy_private_bfd_data_common): Free data
	before returning.
---

diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index 5031fff93d1..ab665ed08ec 100644
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,9 @@
+2018-10-16  Alan Modra  <amodra@gmail.com>
+
+	PR 23781
+	* peXXigen.c (_bfd_XX_bfd_copy_private_bfd_data_common): Free data
+	before returning.
+
 2018-10-16  Alan Modra  <amodra@gmail.com>
 
 	PR 23534
diff --git a/bfd/peXXigen.c b/bfd/peXXigen.c
index 1645ef4b77c..1271d4edbbe 100644
--- a/bfd/peXXigen.c
+++ b/bfd/peXXigen.c
@@ -2993,6 +2993,7 @@ _bfd_XX_bfd_copy_private_bfd_data_common (bfd * ibfd, bfd * obfd)
 		   "exceeds space left in section (%" PRIx64 ")"),
 		 obfd, ope->pe_opthdr.DataDirectory[PE_DEBUG_DATA].Size,
 		 (uint64_t) (section->size - (addr - section->vma)));
+	      free (data);
 	      return FALSE;
 	    }
 	  /* PR 23110.  */
@@ -3002,6 +3003,7 @@ _bfd_XX_bfd_copy_private_bfd_data_common (bfd * ibfd, bfd * obfd)
 	      _bfd_error_handler
 		(_("%pB: Data Directory size (%#lx) is negative"),
 		 obfd, ope->pe_opthdr.DataDirectory[PE_DEBUG_DATA].Size);
+	      free (data);
 	      return FALSE;
 	    }
 
@@ -3030,8 +3032,10 @@ _bfd_XX_bfd_copy_private_bfd_data_common (bfd * ibfd, bfd * obfd)
 	  if (!bfd_set_section_contents (obfd, section, data, 0, section->size))
 	    {
 	      _bfd_error_handler (_("failed to update file offsets in debug directory"));
+	      free (data);
 	      return FALSE;
 	    }
+	  free (data);
 	}
       else if (section)
 	{