From: Tom Tromey <tom@tromey.com>
Date: Wed, 1 Feb 2023 15:25:40 +0000 (-0700)
Subject: Make struct value data members private
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=8f4135314ae6e1a98a36295c85af5b246dfa00ff;p=binutils-gdb.git

Make struct value data members private

This hoists the 'private' in struct value to also encompass the data
members.

Approved-By: Simon Marchi <simon.marchi@efficios.com>
---

diff --git a/gdb/value.h b/gdb/value.h
index 225a3c851c4..7708530ddcc 100644
--- a/gdb/value.h
+++ b/gdb/value.h
@@ -609,6 +609,8 @@ public:
      in the history.  The value is removed from the value chain.  */
   int record_latest ();
 
+private:
+
   /* Type of value; either not an lval, or one of the various
      different possible kinds of lval.  */
   enum lval_type m_lval = not_lval;
@@ -785,8 +787,6 @@ public:
      loaded from the inferior.  */
   ULONGEST m_limited_length = 0;
 
-private:
-
   /* Allocate a value and its contents for type TYPE.  If CHECK_SIZE
      is true, then apply the usual max-value-size checks.  */
   static struct value *allocate (struct type *type, bool check_size);
@@ -806,15 +806,11 @@ private:
      return failure here, which will ultimately throw an error.  */
   bool set_limited_array_length ();
 
-public: /* Temporary */
-
   /* Allocate the contents of this value if it has not been allocated
      yet.  If CHECK_SIZE is true, then apply the usual max-value-size
      checks.  */
   void allocate_contents (bool check_size);
 
-private:
-
   /* Helper function for value_contents_eq.  The only difference is that
      this function is bit rather than byte based.