From: whitequark <whitequark@whitequark.org>
Date: Fri, 23 Aug 2019 08:37:59 +0000 (+0000)
Subject: back.pysim: don't crash when trying to drive a nonexistent domain clock.
X-Git-Tag: locally_working~1
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=906385c7f8d648f140a5bc1693dd09a013e34023;p=nmigen.git

back.pysim: don't crash when trying to drive a nonexistent domain clock.
---

diff --git a/nmigen/back/pysim.py b/nmigen/back/pysim.py
index 25189d7..8471b51 100644
--- a/nmigen/back/pysim.py
+++ b/nmigen/back/pysim.py
@@ -451,6 +451,10 @@ class Simulator:
         for domain_obj in self._domains:
             if not domain_obj.local and domain_obj.name == domain:
                 clk = domain_obj.clk
+                break
+        else:
+            raise ValueError("Domain '{}' is not present in simulation"
+                             .format(domain))
         def clk_process():
             yield Passive()
             yield Delay(phase)
diff --git a/nmigen/test/test_sim.py b/nmigen/test/test_sim.py
index e7d759d..c9cdcb7 100644
--- a/nmigen/test/test_sim.py
+++ b/nmigen/test/test_sim.py
@@ -413,6 +413,13 @@ class SimulatorIntegrationTestCase(FHDLTestCase):
                     msg="Domain 'sync' already has a clock driving it"):
                 sim.add_clock(1)
 
+    def test_add_clock_wrong(self):
+        m = Module()
+        with self.assertSimulation(m) as sim:
+            with self.assertRaises(ValueError,
+                    msg="Domain 'sync' is not present in simulation"):
+                sim.add_clock(1)
+
     def test_eq_signal_unused_wrong(self):
         self.setUp_lhs_rhs()
         self.s = Signal()