From: Daniel Schürmann <daniel@schuermann.dev>
Date: Thu, 2 Apr 2020 17:07:22 +0000 (+0100)
Subject: aco: remove unnecessary reg_file.fill() operation in get_reg_create_vector()
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=90811554da8afca7099abe7c7c66e6b1c009e16f;p=mesa.git

aco: remove unnecessary reg_file.fill() operation in get_reg_create_vector()

No pipelinedb changes

Reviewed-by: Rhys Perry <pendingchaos02@gmail.com>
Reviewed-By: Timur Kristóf <timur.kristof@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4002>
---

diff --git a/src/amd/compiler/aco_register_allocation.cpp b/src/amd/compiler/aco_register_allocation.cpp
index 9dad4291347..5f2be2aa3dc 100644
--- a/src/amd/compiler/aco_register_allocation.cpp
+++ b/src/amd/compiler/aco_register_allocation.cpp
@@ -837,12 +837,11 @@ PhysReg get_reg_create_vector(ra_ctx& ctx,
 
    /* move killed operands which aren't yet at the correct position */
    for (unsigned i = 0, offset = 0; i < instr->operands.size(); offset += instr->operands[i].size(), i++) {
-      if (instr->operands[i].isTemp() && instr->operands[i].isFirstKillBeforeDef() && instr->operands[i].getTemp().type() == rc.type()) {
-         if (instr->operands[i].physReg() != best_pos + offset)
-            vars.emplace(instr->operands[i].size(), instr->operands[i].tempId());
-         else
-            reg_file.fill(instr->operands[i]);
-      }
+      if (instr->operands[i].isTemp() &&
+          instr->operands[i].isFirstKillBeforeDef() &&
+          instr->operands[i].getTemp().type() == rc.type() &&
+          instr->operands[i].physReg() != best_pos + offset)
+         vars.emplace(instr->operands[i].size(), instr->operands[i].tempId());
    }
 
    ASSERTED bool success = false;