From: Tom Tromey <tromey@redhat.com>
Date: Thu, 8 May 2014 16:10:43 +0000 (-0600)
Subject: minor cleanups in is_dynamic_type
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=92e2a17f9b145d35b4a9a2273612d323ccdc9cac;p=binutils-gdb.git

minor cleanups in is_dynamic_type

I noticed that gdbtypes.c:is_dynamic_type has some unneeded "break"s.
This patch cleans up the function a bit, removing those and removing
the switch's default case so that the end of the function is a bit
clearer.

2014-06-04  Tom Tromey  <tromey@redhat.com>

	* gdbtypes.c (is_dynamic_type): Remove unneeded "break"s.
---

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 8e48f1f2c23..ba048574afa 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,7 @@
+2014-06-04  Tom Tromey  <tromey@redhat.com>
+
+	* gdbtypes.c (is_dynamic_type): Remove unneeded "break"s.
+
 2014-06-04  Tom Tromey  <tromey@redhat.com>
 
 	* procfs.c (procfs_attach): Make "args" const.
diff --git a/gdb/gdbtypes.c b/gdb/gdbtypes.c
index 0d7b793c6ec..ba35883ec72 100644
--- a/gdb/gdbtypes.c
+++ b/gdb/gdbtypes.c
@@ -1625,7 +1625,6 @@ is_dynamic_type (struct type *type)
     {
     case TYPE_CODE_RANGE:
       return !has_static_range (TYPE_RANGE_DATA (type));
-      break;
 
     case TYPE_CODE_ARRAY:
       {
@@ -1635,14 +1634,11 @@ is_dynamic_type (struct type *type)
 	   or the elements it contains have a dynamic contents.  */
 	if (is_dynamic_type (TYPE_INDEX_TYPE (type)))
 	  return 1;
-	else
-	  return is_dynamic_type (TYPE_TARGET_TYPE (type));
-	break;
+	return is_dynamic_type (TYPE_TARGET_TYPE (type));
       }
-    default:
-      return 0;
-      break;
     }
+
+  return 0;
 }
 
 static struct type *