From: Eric Anholt Date: Tue, 9 Jun 2015 19:16:19 +0000 (-0700) Subject: egl: Drop check for driver != NULL. X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=932d1613d1e15ec22555e5ec09105c49eb850e36;p=mesa.git egl: Drop check for driver != NULL. Back in 2013, a patch was added (with 2 reviewers!) at the end of the block to early exit the loop in this case, without noticing that the loop already did. I added another early exit case, again without noticing, but Rob caught me. Just drop the loop condition that apparently surprises most of us, instead of leaving the end of the loop conspicuously not exiting on success. Reviewed-by: Ian Romanick Reviewed-by: Rob Clark --- diff --git a/src/egl/drivers/dri2/egl_dri2.c b/src/egl/drivers/dri2/egl_dri2.c index 44a6c96ae9a..dceb9a011d9 100644 --- a/src/egl/drivers/dri2/egl_dri2.c +++ b/src/egl/drivers/dri2/egl_dri2.c @@ -397,7 +397,7 @@ dri2_open_driver(_EGLDisplay *disp) dri2_dpy->driver = NULL; end = search_paths + strlen(search_paths); - for (p = search_paths; p < end && dri2_dpy->driver == NULL; p = next + 1) { + for (p = search_paths; p < end; p = next + 1) { int len; next = strchr(p, ':'); if (next == NULL)