From: Samuel Pitoiset Date: Fri, 25 Nov 2016 11:17:56 +0000 (+0100) Subject: gm107/ir: do not combine CONST loads X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=948cce01964c1dd7365c49381f9a6cf1b6e5f7f9;p=mesa.git gm107/ir: do not combine CONST loads This will allow to use MOV instead of LD. The main advantage is that MOV doesn't require a read dependency barrier while LD does, and so this will both reduce barriers pressure and the number of stall counts needed to read data from constant memory. This is currently only for user uniform accesses. I should do something similar when loading from the driver constant buffer but it seems like a bit tricky to handle for now. Signed-off-by: Samuel Pitoiset Reviewed-by: Ilia Mirkin --- diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_target_nvc0.cpp b/src/gallium/drivers/nouveau/codegen/nv50_ir_target_nvc0.cpp index 2d1f1b45247..8a67b0afbca 100644 --- a/src/gallium/drivers/nouveau/codegen/nv50_ir_target_nvc0.cpp +++ b/src/gallium/drivers/nouveau/codegen/nv50_ir_target_nvc0.cpp @@ -406,8 +406,13 @@ TargetNVC0::isAccessSupported(DataFile file, DataType ty) const { if (ty == TYPE_NONE) return false; - if (file == FILE_MEMORY_CONST && getChipset() >= 0xe0) // wrong encoding ? - return typeSizeof(ty) <= 8; + if (file == FILE_MEMORY_CONST) { + if (getChipset() >= NVISA_GM107_CHIPSET) + return typeSizeof(ty) <= 4; + else + if (getChipset() >= NVISA_GK104_CHIPSET) // wrong encoding ? + return typeSizeof(ty) <= 8; + } if (ty == TYPE_B96) return false; return true;