From: Ian Romanick <ian.d.romanick@intel.com>
Date: Wed, 15 Apr 2015 22:20:57 +0000 (-0700)
Subject: nir: Convert the if-test for num_inputs == 2 to an assertion
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=94aab6cde696ab1cd1243f5c62444166efb1a2fa;p=mesa.git

nir: Convert the if-test for num_inputs == 2 to an assertion

Suggested by Jason on a different patch after some comments /
questions by Ilia.

Signed-off-by: Ian Romanick <ian.d.romanick@intel.com>
Reviewed-by: Jason Ekstrand <jason.ekstrand@intel.com>
Reviewed-by: Connor Abbott <cwabott0@gmail.com>
---

diff --git a/src/glsl/nir/nir_search.c b/src/glsl/nir/nir_search.c
index 73a802be705..5ba016085fc 100644
--- a/src/glsl/nir/nir_search.c
+++ b/src/glsl/nir/nir_search.c
@@ -218,8 +218,8 @@ match_expression(const nir_search_expression *expr, nir_alu_instr *instr,
    if (matched)
       return true;
 
-   if (nir_op_infos[instr->op].num_inputs == 2 &&
-       (nir_op_infos[instr->op].algebraic_properties & NIR_OP_IS_COMMUTATIVE)) {
+   if (nir_op_infos[instr->op].algebraic_properties & NIR_OP_IS_COMMUTATIVE) {
+      assert(nir_op_infos[instr->op].num_inputs == 2);
       if (!match_value(expr->srcs[0], instr, 1, num_components,
                        swizzle, state))
          return false;