From: Tom Tromey <tromey@adacore.com>
Date: Tue, 12 Apr 2022 20:40:16 +0000 (-0600)
Subject: Don't call QUIT in read_string
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=94ea6ddb944d985890632708865ffef4436f98c3;p=binutils-gdb.git

Don't call QUIT in read_string

read_string does not need to call QUIT, because target_read_memory
already does.  This change is needed to make string-reading usable by
gdbserver.
---

diff --git a/gdb/valprint.c b/gdb/valprint.c
index 9990d432e35..65b85cfb038 100644
--- a/gdb/valprint.c
+++ b/gdb/valprint.c
@@ -2096,7 +2096,6 @@ read_string (CORE_ADDR addr, int len, int width, unsigned int fetchlimit,
 
       do
 	{
-	  QUIT;
 	  nfetch = std::min ((unsigned long) chunksize, fetchlimit - bufsize);
 
 	  if (*buffer == NULL)
@@ -2152,8 +2151,6 @@ read_string (CORE_ADDR addr, int len, int width, unsigned int fetchlimit,
      consider part of the string (including a '\0' which ends the string).  */
   *bytes_read = bufptr - buffer->get ();
 
-  QUIT;
-
   return errcode;
 }