From: Srikant Bharadwaj Date: Thu, 10 Sep 2020 06:31:43 +0000 (-0400) Subject: mem-garnet: Fix default value of network bridge X-Git-Tag: v20.1.0.0~36 X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=94f7736489fdc1a5ecb7026fafee524c203fcfd4;p=gem5.git mem-garnet: Fix default value of network bridge Initializing the network bridge with NULL causes it to have an class error when instatiating a link. The bridge is only needed whne either a CDC or SerDes is enabled. This is handled later during construction of the GarnetLink. Change-Id: If19a21a6d9bf49449b9c390467d08d3422ae991a Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/34257 Reviewed-by: Jason Lowe-Power Maintainer: Jason Lowe-Power Tested-by: kokoro --- diff --git a/src/mem/ruby/network/garnet2.0/GarnetLink.py b/src/mem/ruby/network/garnet2.0/GarnetLink.py index 33a3d3149..9f7fe8b14 100644 --- a/src/mem/ruby/network/garnet2.0/GarnetLink.py +++ b/src/mem/ruby/network/garnet2.0/GarnetLink.py @@ -140,14 +140,14 @@ class GarnetExtLink(BasicExtLink): # The network bridge encapsulates both the CDC and Ser-Des # units in HeteroGarnet. This is automatically enabled when # either CDC or Ser-Des is enabled. - ext_net_bridge = VectorParam.NetworkBridge(NULL, + ext_net_bridge = VectorParam.NetworkBridge([], "Network Bridge at external end") - ext_cred_bridge = VectorParam.NetworkBridge(NULL, + ext_cred_bridge = VectorParam.NetworkBridge([], "Credit Bridge at external end") - int_net_bridge = VectorParam.NetworkBridge(NULL, + int_net_bridge = VectorParam.NetworkBridge([], "Network Bridge at internal end") - int_cred_bridge = VectorParam.NetworkBridge(NULL, - "Credit Bridge at intternal end") + int_cred_bridge = VectorParam.NetworkBridge([], + "Credit Bridge at internal end") width = Param.UInt32(Parent.ni_flit_size,