From: Tom Tromey Date: Wed, 30 Sep 2020 00:49:08 +0000 (-0600) Subject: Rename struct attribute accessors X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=95f982e587ddd0bf9a4799853982e7cc726280ad;p=binutils-gdb.git Rename struct attribute accessors This removes the "value_" prefix from the struct value accessors. This seemed unnecessarily wordy to me. gdb/ChangeLog 2020-09-29 Tom Tromey * dwarf2/read.c (dwarf2_find_base_address, read_call_site_scope) (dwarf2_get_pc_bounds, dwarf2_record_block_ranges) (partial_die_info::read, dwarf2_string_attr, new_symbol): Update. * dwarf2/attribute.h (struct attribute): Rename methods. * dwarf2/attribute.c (attribute::as_address): Rename from value_as_address. (attribute::as_string): Rename from value_as_string. --- diff --git a/gdb/ChangeLog b/gdb/ChangeLog index cd5958ccc44..b561f8a8302 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,13 @@ +2020-09-29 Tom Tromey + + * dwarf2/read.c (dwarf2_find_base_address, read_call_site_scope) + (dwarf2_get_pc_bounds, dwarf2_record_block_ranges) + (partial_die_info::read, dwarf2_string_attr, new_symbol): Update. + * dwarf2/attribute.h (struct attribute): Rename methods. + * dwarf2/attribute.c (attribute::as_address): Rename from + value_as_address. + (attribute::as_string): Rename from value_as_string. + 2020-09-29 Tom Tromey * dwarf2/read.c (partial_die_info::read) base_address = attr->value_as_address (); + cu->base_address = attr->as_address (); else { attr = dwarf2_attr (die, DW_AT_low_pc, cu); if (attr != nullptr) - cu->base_address = attr->value_as_address (); + cu->base_address = attr->as_address (); } } @@ -13829,7 +13829,7 @@ read_call_site_scope (struct die_info *die, struct dwarf2_cu *cu) sect_offset_str (die->sect_off), objfile_name (objfile)); return; } - pc = attr->value_as_address () + baseaddr; + pc = attr->as_address () + baseaddr; pc = gdbarch_adjust_dwarf2_addr (gdbarch, pc); if (cu->call_site_htab == NULL) @@ -14568,8 +14568,8 @@ dwarf2_get_pc_bounds (struct die_info *die, CORE_ADDR *lowpc, attr = dwarf2_attr (die, DW_AT_low_pc, cu); if (attr != nullptr) { - low = attr->value_as_address (); - high = attr_high->value_as_address (); + low = attr->as_address (); + high = attr_high->as_address (); if (cu->header.version >= 4 && attr_high->form_is_constant ()) high += low; } @@ -14748,8 +14748,8 @@ dwarf2_record_block_ranges (struct die_info *die, struct block *block, attr = dwarf2_attr (die, DW_AT_low_pc, cu); if (attr != nullptr) { - CORE_ADDR low = attr->value_as_address (); - CORE_ADDR high = attr_high->value_as_address (); + CORE_ADDR low = attr->as_address (); + CORE_ADDR high = attr_high->as_address (); if (cu->header.version >= 4 && attr_high->form_is_constant ()) high += low; @@ -19030,15 +19030,15 @@ partial_die_info::read (const struct die_reader_specs *reader, /* Note that both forms of linkage name might appear. We assume they will be the same, and we only store the last one we see. */ - linkage_name = attr.value_as_string (); + linkage_name = attr.as_string (); break; case DW_AT_low_pc: has_low_pc_attr = 1; - lowpc = attr.value_as_address (); + lowpc = attr.as_address (); break; case DW_AT_high_pc: has_high_pc_attr = 1; - highpc = attr.value_as_address (); + highpc = attr.as_address (); if (cu->header.version >= 4 && attr.form_is_constant ()) high_pc_relative = 1; break; @@ -20276,7 +20276,7 @@ dwarf2_string_attr (struct die_info *die, unsigned int name, struct dwarf2_cu *c if (attr != NULL) { - str = attr->value_as_string (); + str = attr->as_string (); if (str == nullptr) complaint (_("string type expected for attribute %s for " "DIE at %s in module %s"), @@ -21453,7 +21453,7 @@ new_symbol (struct die_info *die, struct type *type, struct dwarf2_cu *cu, { CORE_ADDR addr; - addr = attr->value_as_address (); + addr = attr->as_address (); addr = gdbarch_adjust_dwarf2_addr (gdbarch, addr + baseaddr); SET_SYMBOL_VALUE_ADDRESS (sym, addr); SYMBOL_ACLASS_INDEX (sym) = LOC_LABEL;