From: Pedro Alves <palves@redhat.com>
Date: Fri, 19 Apr 2013 15:23:18 +0000 (+0000)
Subject: -Wpointer-sign: aarch64-tdep.c.
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=96b32e50dd5d7fee19c94b58fd8e32cd02760637;p=binutils-gdb.git

-Wpointer-sign: aarch64-tdep.c.

../../src/gdb/aarch64-tdep.c: In function ‘aarch64_analyze_prologue’:
../../src/gdb/aarch64-tdep.c:713:7: error: pointer targets in passing argument 3 of ‘decode_cb’ differ in signedness [-Werror=pointer-sign]
../../src/gdb/aarch64-tdep.c:386:1: note: expected ‘int *’ but argument is of type ‘unsigned int *’
../../src/gdb/aarch64-tdep.c:747:7: error: pointer targets in passing argument 3 of ‘decode_stur’ differ in signedness [-Werror=pointer-sign]
../../src/gdb/aarch64-tdep.c:597:1: note: expected ‘int *’ but argument is of type ‘unsigned int *’


'is64' is just used as a boolean; signed/unsigned doesn't really matter.

2013-04-19  Pedro Alves  <palves@redhat.com>

	* aarch64-tdep.c (aarch64_analyze_prologue): Change type of local
	'is64' to signed 'int'.
---

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 4ce4ffa40d2..39650bcea0b 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2013-04-19  Pedro Alves  <palves@redhat.com>
+
+	* aarch64-tdep.c (aarch64_analyze_prologue): Change type of local
+	'is64' to signed 'int'.
+
 2013-04-19  Pedro Alves  <palves@redhat.com>
 
 	* s390-tdep.c (is_rs, is_rsy, is_rx, is_rxy): Change type of 'd2'
diff --git a/gdb/aarch64-tdep.c b/gdb/aarch64-tdep.c
index b151f9d02dc..8c38ef3d6cd 100644
--- a/gdb/aarch64-tdep.c
+++ b/gdb/aarch64-tdep.c
@@ -683,7 +683,7 @@ aarch64_analyze_prologue (struct gdbarch *gdbarch,
       int op_is_sub;
       int32_t imm;
       unsigned cond;
-      unsigned is64;
+      int is64;
       unsigned is_link;
       unsigned op;
       unsigned bit;