From: Kenneth Graunke <kenneth@whitecape.org>
Date: Fri, 19 Oct 2018 04:15:02 +0000 (-0700)
Subject: iris: leave XXX about unnecessary binding table uploads
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=973b937cac02a17b8fd23d69cdecda7579973bcb;p=mesa.git

iris: leave XXX about unnecessary binding table uploads
---

diff --git a/src/gallium/drivers/iris/iris_state.c b/src/gallium/drivers/iris/iris_state.c
index 0a1127440f1..f36838262e5 100644
--- a/src/gallium/drivers/iris/iris_state.c
+++ b/src/gallium/drivers/iris/iris_state.c
@@ -4309,6 +4309,8 @@ iris_upload_compute_state(struct iris_context *ice,
                          .stride_B = 1,
                          .mocs = MOCS_WB);
 
+   // XXX: this will update the binding table on every dispatch, should
+   // XXX: check if the grid size actually changed (or indirect buf changed)
    if (dirty & IRIS_DIRTY_BINDINGS_CS || grid_size_res)
       iris_populate_binding_table(ice, batch, MESA_SHADER_COMPUTE, false,
                                   &grid_size_surf);