From: Paolo Carlini <paolo.carlini@oracle.com>
Date: Tue, 17 Nov 2009 20:03:03 +0000 (+0000)
Subject: re PR c++/42058 (Trouble with invalid array initialization)
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=97471c71bfe5d692043166106599eca3374b0370;p=gcc.git

re PR c++/42058 (Trouble with invalid array initialization)

cp/
2009-11-17  Paolo Carlini  <paolo.carlini@oracle.com>

	PR c++/42058
	* typeck2.c (digest_init_r): Check init for error_operand_p.
	* decl.c (reshape_init_class): Check return value of reshape_init_r
	for error_mark_node.

testsuite/
2009-11-17  Paolo Carlini  <paolo.carlini@oracle.com>

	PR c++/42058
	* testsuite/g++.dg/init/array26.C: New.
	* testsuite/g++.dg/init/array27.C: Likewise.
	* testsuite/g++.old-deja/g++.benjamin/13478.C: Adjust dg-errors.

From-SVN: r154267
---

diff --git a/gcc/cp/ChangeLog b/gcc/cp/ChangeLog
index 4f5f9b54248..17968f50860 100644
--- a/gcc/cp/ChangeLog
+++ b/gcc/cp/ChangeLog
@@ -1,3 +1,10 @@
+2009-11-17  Paolo Carlini  <paolo.carlini@oracle.com>
+
+	PR c++/42058
+	* typeck2.c (digest_init_r): Check init for error_operand_p.
+	* decl.c (reshape_init_class): Check return value of reshape_init_r
+	for error_mark_node.
+
 2009-11-17  Jakub Jelinek  <jakub@redhat.com>
 
 	PR c++/42061
diff --git a/gcc/cp/decl.c b/gcc/cp/decl.c
index 851edeb5251..f57efb70d2d 100644
--- a/gcc/cp/decl.c
+++ b/gcc/cp/decl.c
@@ -4878,6 +4878,9 @@ reshape_init_class (tree type, reshape_iter *d, bool first_initializer_p)
 
       field_init = reshape_init_r (TREE_TYPE (field), d,
 				   /*first_initializer_p=*/false);
+      if (field_init == error_mark_node)
+	return error_mark_node;
+
       CONSTRUCTOR_APPEND_ELT (CONSTRUCTOR_ELTS (new_init), field, field_init);
 
       /* [dcl.init.aggr]
diff --git a/gcc/cp/typeck2.c b/gcc/cp/typeck2.c
index 96fa442f6d1..6cb115202b2 100644
--- a/gcc/cp/typeck2.c
+++ b/gcc/cp/typeck2.c
@@ -723,7 +723,7 @@ digest_init_r (tree type, tree init, bool nested, int flags)
 {
   enum tree_code code = TREE_CODE (type);
 
-  if (init == error_mark_node)
+  if (error_operand_p (init))
     return error_mark_node;
 
   gcc_assert (init);
diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index f73a427fa09..0cbfda25625 100644
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,10 @@
+2009-11-17  Paolo Carlini  <paolo.carlini@oracle.com>
+
+	PR c++/42058
+	* testsuite/g++.dg/init/array26.C: New.
+	* testsuite/g++.dg/init/array27.C: Likewise.
+	* testsuite/g++.old-deja/g++.benjamin/13478.C: Adjust dg-errors.
+
 2009-11-17  Jakub Jelinek  <jakub@redhat.com>
 
 	PR c++/42061
diff --git a/gcc/testsuite/g++.dg/init/array26.C b/gcc/testsuite/g++.dg/init/array26.C
new file mode 100644
index 00000000000..83c4e0c4a4d
--- /dev/null
+++ b/gcc/testsuite/g++.dg/init/array26.C
@@ -0,0 +1,11 @@
+// PR c++/42058
+// { dg-options "" }
+
+struct A;
+
+struct B
+{
+  A a; // { dg-error "incomplete type" }
+};
+
+B b[1] = (B[]) { 0 }; // { dg-error "initializer" }
diff --git a/gcc/testsuite/g++.dg/init/array27.C b/gcc/testsuite/g++.dg/init/array27.C
new file mode 100644
index 00000000000..988501545f0
--- /dev/null
+++ b/gcc/testsuite/g++.dg/init/array27.C
@@ -0,0 +1,11 @@
+// PR c++/42058
+// { dg-options "" }
+
+struct A {};
+
+struct B
+{
+  A a;
+};
+
+B b[1] = (B[]) { 0 }; // { dg-error "initializer" }
diff --git a/gcc/testsuite/g++.old-deja/g++.benjamin/13478.C b/gcc/testsuite/g++.old-deja/g++.benjamin/13478.C
index 7b560b94235..e1d52e14b06 100644
--- a/gcc/testsuite/g++.old-deja/g++.benjamin/13478.C
+++ b/gcc/testsuite/g++.old-deja/g++.benjamin/13478.C
@@ -27,10 +27,4 @@ const hand_table Agent::table_1[] =
    {0,     &Agent::table_2},
    {first, &Agent::foo},
    {last,  &(hand)Agent::foo} // { dg-error "" } no match
-}; // { dg-error "" } cannot convert
-
-
-
-
-
-
+};