From: Tom Tromey <tom@tromey.com>
Date: Wed, 3 May 2017 23:28:08 +0000 (-0600)
Subject: Don't copy a string in mi_cmd_disassemble
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=9813429a729dbcd761dfbb02d2d7a3449af0881d;p=binutils-gdb.git

Don't copy a string in mi_cmd_disassemble

This string copy in mi_cmd_disassemble seems not to be needed, so
don't do it.

gdb/ChangeLog
2017-09-29  Tom Tromey  <tom@tromey.com>

	* mi/mi-cmd-disas.c (mi_cmd_disassemble): Don't copy "oarg".
---

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 2aaaabead73..004e0b0f0ff 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,7 @@
+2017-09-29  Tom Tromey  <tom@tromey.com>
+
+	* mi/mi-cmd-disas.c (mi_cmd_disassemble): Don't copy "oarg".
+
 2017-09-29  Tom Tromey  <tom@tromey.com>
 
 	* varobj.h (varobj_gen_name): Return std::string.
diff --git a/gdb/mi/mi-cmd-disas.c b/gdb/mi/mi-cmd-disas.c
index d0f9b0b83ad..b3d6245c2cc 100644
--- a/gdb/mi/mi-cmd-disas.c
+++ b/gdb/mi/mi-cmd-disas.c
@@ -74,7 +74,6 @@ mi_cmd_disassemble (const char *command, char **argv, int argc)
   int how_many = -1;
   CORE_ADDR low = 0;
   CORE_ADDR high = 0;
-  struct cleanup *cleanups = make_cleanup (null_cleanup, NULL);
 
   /* Options processing stuff.  */
   int oind = 0;
@@ -104,9 +103,8 @@ mi_cmd_disassemble (const char *command, char **argv, int argc)
       switch ((enum opt) opt)
 	{
 	case FILE_OPT:
-	  file_string = xstrdup (oarg);
+	  file_string = oarg;
 	  file_seen = 1;
-	  make_cleanup (xfree, file_string);
 	  break;
 	case LINE_OPT:
 	  line_num = atoi (oarg);
@@ -190,6 +188,4 @@ mi_cmd_disassemble (const char *command, char **argv, int argc)
   gdb_disassembly (gdbarch, uiout,
   		   disasm_flags,
 		   how_many, low, high);
-
-  do_cleanups (cleanups);
 }