From: Jason Ekstrand <jason.ekstrand@intel.com>
Date: Wed, 3 Jan 2018 17:05:31 +0000 (-0800)
Subject: spirv: Require a storage type for OpStore destinations
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=986303cb928f1de3297c3f52a8ea52971e222472;p=mesa.git

spirv: Require a storage type for OpStore destinations

This rules out things such as trying to store a pointer to a local
variable.

Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
---

diff --git a/src/compiler/spirv/vtn_variables.c b/src/compiler/spirv/vtn_variables.c
index 2b3b3405e4d..399860b8085 100644
--- a/src/compiler/spirv/vtn_variables.c
+++ b/src/compiler/spirv/vtn_variables.c
@@ -2009,6 +2009,10 @@ vtn_handle_variables(struct vtn_builder *b, SpvOp opcode,
       struct vtn_pointer *dest = dest_val->pointer;
       struct vtn_value *src_val = vtn_untyped_value(b, w[2]);
 
+      /* OpStore requires us to actually have a storage type */
+      vtn_fail_if(dest->type->type == NULL,
+                  "Invalid destination type for OpStore");
+
       vtn_fail_if(dest_val->type->deref != src_val->type,
                   "Value and pointer types of OpStore do not match");