From: Jan Beulich <jbeulich@suse.com>
Date: Mon, 7 Jun 2021 10:01:45 +0000 (+0200)
Subject: x86/Intel: drop unnecessary bracket matching from parse_operands()
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=98ff9f1c5d0bff7545d508288a5699522277d570;p=binutils-gdb.git

x86/Intel: drop unnecessary bracket matching from parse_operands()

While subsequent processing in AT&T mode relies on this simplistic early
checking, Intel mode hasn't been for quite a long time (or perhaps never
really did).
---

diff --git a/gas/ChangeLog b/gas/ChangeLog
index 2f11767b5be..66e040aaa14 100644
--- a/gas/ChangeLog
+++ b/gas/ChangeLog
@@ -1,3 +1,8 @@
+2021-06-07  Jan Beulich  <jbeulich@suse.com>
+
+	* config/tc-i386.c (parse_operands): Don't check for matched
+	square brackets.
+
 2021-06-07  Jan Beulich  <jbeulich@suse.com>
 
 	* config/tc-i386.c (check_VecOperations): Remove 2nd parameter.
diff --git a/gas/config/tc-i386.c b/gas/config/tc-i386.c
index 3a59ea086ac..a20aea28718 100644
--- a/gas/config/tc-i386.c
+++ b/gas/config/tc-i386.c
@@ -5556,12 +5556,9 @@ parse_operands (char *l, const char *mnemonic)
 	    {
 	      if (paren_not_balanced)
 		{
-		  if (!intel_syntax)
-		    as_bad (_("unbalanced parenthesis in operand %d."),
-			    i.operands + 1);
-		  else
-		    as_bad (_("unbalanced brackets in operand %d."),
-			    i.operands + 1);
+		  know (!intel_syntax);
+		  as_bad (_("unbalanced parenthesis in operand %d."),
+			  i.operands + 1);
 		  return NULL;
 		}
 	      else
@@ -5581,13 +5578,6 @@ parse_operands (char *l, const char *mnemonic)
 	      if (*l == ')')
 		--paren_not_balanced;
 	    }
-	  else
-	    {
-	      if (*l == '[')
-		++paren_not_balanced;
-	      if (*l == ']')
-		--paren_not_balanced;
-	    }
 	  l++;
 	}
       if (l != token_start)