From: Simon Marchi <simon.marchi@polymtl.ca>
Date: Fri, 3 Dec 2021 21:35:37 +0000 (-0500)
Subject: gdb/linespec.c: simplify condition
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=9931e521bf3a057cc2770eb92906c2ae38335c5a;p=binutils-gdb.git

gdb/linespec.c: simplify condition

We can remove the empty check: if the vector has size 1, it is obviously
not empty.  This code ended up like this because the empty check used to
be a NULL check.

Change-Id: I1571bd0228818ca93f6a6b444e9b010dc2da4c08
---

diff --git a/gdb/linespec.c b/gdb/linespec.c
index 56bfaede9d9..44134665ac7 100644
--- a/gdb/linespec.c
+++ b/gdb/linespec.c
@@ -2085,8 +2085,7 @@ canonicalize_linespec (struct linespec_state *state, const linespec *ls)
       if (explicit_loc->function_name == NULL)
 	{
 	  /* No function was specified, so add the symbol name.  */
-	  gdb_assert (!ls->labels.function_symbols->empty ()
-		      && (ls->labels.function_symbols->size () == 1));
+	  gdb_assert (ls->labels.function_symbols->size () == 1);
 	  block_symbol s = ls->labels.function_symbols->front ();
 	  explicit_loc->function_name = xstrdup (s.symbol->natural_name ());
 	}