From: Yann E. MORIN Date: Sat, 11 Apr 2020 08:12:26 +0000 (+0200) Subject: package/pkg-utils: show-info: do not show install types for host packages X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=9a9048e069707f369c55146dd6d64b7f913470e7;p=buildroot.git package/pkg-utils: show-info: do not show install types for host packages By their very nature, host packages have no target, staging, or images install steps; they have a single install step, that is always performed. However, we currently report those three types of install, which is misleading at best, and really incorrect. If we were to report any install type for host package, that would be a single one, and it would always be true. So, do not report any install type for host packages, as it does not make sense to report anything that is always true. Signed-off-by: Yann E. MORIN Cc: Vadim Kochan Cc: Thomas Petazzoni Cc: Arnout Vandecappelle Cc: eeppeliteloop@gmail.com Signed-off-by: Thomas Petazzoni --- diff --git a/package/pkg-utils.mk b/package/pkg-utils.mk index d324934dba..14101fcc2a 100644 --- a/package/pkg-utils.mk +++ b/package/pkg-utils.mk @@ -112,9 +112,11 @@ define _json-info-pkg-details "version": "$($(1)_DL_VERSION)", "licenses": "$($(1)_LICENSE)", "dl_dir": "$($(1)_DL_SUBDIR)", - "install_target": $(call yesno-to-bool,$($(1)_INSTALL_TARGET)), - "install_staging": $(call yesno-to-bool,$($(1)_INSTALL_STAGING)), - "install_images": $(call yesno-to-bool,$($(1)_INSTALL_IMAGES)), + $(if $(filter target,$($(1)_TYPE)), \ + "install_target": $(call yesno-to-bool,$($(1)_INSTALL_TARGET))$(comma) \ + "install_staging": $(call yesno-to-bool,$($(1)_INSTALL_STAGING))$(comma) \ + "install_images": $(call yesno-to-bool,$($(1)_INSTALL_IMAGES))$(comma) \ + ) "downloads": [ $(foreach dl,$(sort $($(1)_ALL_DOWNLOADS)), {