From: Alan Modra <amodra@gmail.com>
Date: Sat, 20 Jul 2019 01:17:20 +0000 (+0930)
Subject: PR24827, Linker loops forever if unterminated multi-line comment in script
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=9ab3a74416dac187d56fcf292b39b681d1362dae;p=binutils-gdb.git

PR24827, Linker loops forever if unterminated multi-line comment in script

YY_INPUT returns 0 on end of input, not EOF.

	PR 24827
	* ldlex.l (comment): Check for 0 return from input(), not EOF.
---

diff --git a/ld/ChangeLog b/ld/ChangeLog
index 9fcc55ce3c4..4145096afc8 100644
--- a/ld/ChangeLog
+++ b/ld/ChangeLog
@@ -1,3 +1,8 @@
+2019-07-20  Alan Modra  <amodra@gmail.com>
+
+	PR 24827
+	* ldlex.l (comment): Check for 0 return from YY_INPUT, not EOF.
+
 2019-07-19  Alan Modra  <amodra@gmail.com>
 
 	* testsuite/ld-powerpc/tlsgd.d,
diff --git a/ld/ldlex.l b/ld/ldlex.l
index c2abc59571d..a5c3ba59992 100644
--- a/ld/ldlex.l
+++ b/ld/ldlex.l
@@ -675,7 +675,7 @@ comment (void)
   while (1)
     {
       c = input();
-      while (c != '*' && c != EOF)
+      while (c != '*' && c != 0)
 	{
 	  if (c == '\n')
 	    lineno++;
@@ -694,7 +694,7 @@ comment (void)
       if (c == '\n')
 	lineno++;
 
-      if (c == EOF)
+      if (c == 0)
 	{
 	  einfo (_("%F%P: EOF in comment\n"));
 	  break;