From: Uros Bizjak Date: Tue, 20 Sep 2016 17:36:03 +0000 (+0200) Subject: re PR tree-optimization/77621 (Internal compiler error for mtune=atom + msse2) X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=9b1ba33cf61cc1ca76bacd1eb3a41fe0eb5d12e9;p=gcc.git re PR tree-optimization/77621 (Internal compiler error for mtune=atom + msse2) PR target/77621 * config/i386/i386.c (ix86_preferred_simd_mode) : Don't return word_mode for !TARGET_VECTORIZE_DOUBLE. (ix86_add_stmt_cost): Penalize DFmode vector operations for !TARGET_VECTORIZE_DOUBLE. testsuite/ChangeLog: PR target/77621 * gcc.target/i386/pr77621.c: New test. * gcc.target/i386/vect-double-2.c: Update scan-tree-dump-times pattern, loop should vectorize with -mtune=atom. From-SVN: r240277 --- diff --git a/gcc/ChangeLog b/gcc/ChangeLog index ac7426515c3..e92ad3866e4 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,11 @@ +2016-09-20 Uros Bizjak + + PR target/77621 + * config/i386/i386.c (ix86_preferred_simd_mode) : + Don't return word_mode for !TARGET_VECTORIZE_DOUBLE. + (ix86_add_stmt_cost): Penalize DFmode vector operations + for !TARGET_VECTORIZE_DOUBLE. + 2016-09-20 Gerald Pfeifer * doc/invoke.texi (Warning Options): Simplify language. diff --git a/gcc/config/i386/i386.c b/gcc/config/i386/i386.c index 60b81bbb8ab..ff057dc60f9 100644 --- a/gcc/config/i386/i386.c +++ b/gcc/config/i386/i386.c @@ -49554,9 +49554,7 @@ ix86_preferred_simd_mode (machine_mode mode) return V4SFmode; case DFmode: - if (!TARGET_VECTORIZE_DOUBLE) - return word_mode; - else if (TARGET_AVX512F) + if (TARGET_AVX512F) return V8DFmode; else if (TARGET_AVX && !TARGET_PREFER_AVX128) return V4DFmode; @@ -49647,9 +49645,14 @@ ix86_add_stmt_cost (void *data, int count, enum vect_cost_for_stmt kind, tree vectype = stmt_info ? stmt_vectype (stmt_info) : NULL_TREE; int stmt_cost = ix86_builtin_vectorization_cost (kind, vectype, misalign); + /* Penalize DFmode vector operations for !TARGET_VECTORIZE_DOUBLE. */ + if (kind == vector_stmt && !TARGET_VECTORIZE_DOUBLE + && vectype && GET_MODE_INNER (TYPE_MODE (vectype)) == DFmode) + stmt_cost *= 5; /* FIXME: The value here is arbitrary. */ + /* Statements in an inner loop relative to the loop being vectorized are weighted more heavily. The value here is - arbitrary and could potentially be improved with analysis. */ + arbitrary and could potentially be improved with analysis. */ if (where == vect_body && stmt_info && stmt_in_inner_loop_p (stmt_info)) count *= 50; /* FIXME. */ diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index d515fdf5bcf..89024bb89d0 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,10 @@ +2016-09-20 Uros Bizjak + + PR target/77621 + * gcc.target/i386/pr77621.c: New test. + * gcc.target/i386/vect-double-2.c: Update scan-tree-dump-times + pattern, loop should vectorize with -mtune=atom. + 2016-09-20 Maxim Ostapenko Jakub Jelinek diff --git a/gcc/testsuite/gcc.target/i386/pr77621.c b/gcc/testsuite/gcc.target/i386/pr77621.c new file mode 100644 index 00000000000..0de2ef38764 --- /dev/null +++ b/gcc/testsuite/gcc.target/i386/pr77621.c @@ -0,0 +1,12 @@ +/* { dg-do compile } */ +/* { dg-options "-O3 -mtune=atom -msse2 -fdump-tree-vect-stats" } */ + +void +foo (double *x, int *y) +{ + int i; + for (i = 0; i < 8; i++) + x[i] -= y[i] * x[i + 1]; +} + +/* { dg-final { scan-tree-dump-not "Vectorized loops: 1" "vect" } } */ diff --git a/gcc/testsuite/gcc.target/i386/vect-double-2.c b/gcc/testsuite/gcc.target/i386/vect-double-2.c index b30d848c73d..f6a43749407 100644 --- a/gcc/testsuite/gcc.target/i386/vect-double-2.c +++ b/gcc/testsuite/gcc.target/i386/vect-double-2.c @@ -31,4 +31,4 @@ sse2_test (void) } } -/* { dg-final { scan-tree-dump-not "vectorized 1 loops" "vect" } } */ +/* { dg-final { scan-tree-dump-times "Vectorized loops: 1" 1 "vect" } } */