From: Kenneth Graunke <kenneth@whitecape.org>
Date: Wed, 12 Apr 2017 16:53:44 +0000 (-0700)
Subject: intel/decoder: Fix is_header_field starting condition.
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=9b71709cb8532cda4bfbbcbf4d0d86d53c0dffb9;p=mesa.git

intel/decoder: Fix is_header_field starting condition.

Starting positions >= 32 are not part of the header, rather than >.

Caught by Coverity, which found that "bits <<= field->start" may shift
by 32, which has undefined behavior.

CID: 1404968

Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
---

diff --git a/src/intel/common/gen_decoder.c b/src/intel/common/gen_decoder.c
index 03c9c7f8d46..e3327d38542 100644
--- a/src/intel/common/gen_decoder.c
+++ b/src/intel/common/gen_decoder.c
@@ -849,7 +849,7 @@ is_header_field(struct gen_group *group, struct gen_field *field)
 {
    uint32_t bits;
 
-   if (field->start > 32)
+   if (field->start >= 32)
       return false;
 
    bits = (1U << (field->end - field->start + 1)) - 1;