From: Alejandro Piñeiro Date: Fri, 6 May 2016 14:13:26 +0000 (+0200) Subject: mesa/formatquery: expand NUM_SAMPLE_COUNTS OpenGL ES comment X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=9bdbb9c0e0d0fb73831c590eb9626a3298f55982;p=mesa.git mesa/formatquery: expand NUM_SAMPLE_COUNTS OpenGL ES comment For ES 3.0 NUM_SAMPLE_COUNTS spec points that some formats will be always zero. But on ES 3.1 can be different to zero. The current code is correctly checking exactly against version 3.0, but the comment only mentions 3.0 spec. It is clearer mentioning both. v2: better wording on the comment (Ian Romanick) Acked-by: Eduardo Lima Acked-by: Antia Puentes Reviewed-by: Ian Romanick --- diff --git a/src/mesa/main/formatquery.c b/src/mesa/main/formatquery.c index 1f21d17fff6..f524619d98e 100644 --- a/src/mesa/main/formatquery.c +++ b/src/mesa/main/formatquery.c @@ -877,6 +877,9 @@ _mesa_GetInternalformativ(GLenum target, GLenum internalformat, GLenum pname, * "Since multisampling is not supported for signed and unsigned * integer internal formats, the value of NUM_SAMPLE_COUNTS will be * zero for such formats. + * + * Since OpenGL ES 3.1 adds support for multisampled integer formats, we + * have to check the version for 30 exactly. */ if (pname == GL_NUM_SAMPLE_COUNTS && ctx->API == API_OPENGLES2 && ctx->Version == 30 && _mesa_is_enum_format_integer(internalformat)) {