From: Pedro Alves <pedro@palves.net>
Date: Thu, 21 Apr 2022 12:35:09 +0000 (+0100)
Subject: gdb.debuginfod/fetch_src_and_symbols.exp: Fix "notice empty URL" test
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=9cf71b1354f6829a999b39a675a18c5a85f19e17;p=binutils-gdb.git

gdb.debuginfod/fetch_src_and_symbols.exp: Fix "notice empty URL" test

The gdb_test_multiple pattern for the "notice empty URL" test in
gdb.debuginfod/fetch_src_and_symbols.exp misses expecting the prompt.
Fix it by using -re -wrap.

Also, by using "confirm off", the message GDB prints if Debuginfod
downloading is available doesn't contain "Enable debuginfod" any
longer.  E.g.:

~~~
  (gdb) file testsuite/outputs/gdb.debuginfod/fetch_src_and_symbols/fetch_src_and_symbols
  Reading symbols from testsuite/outputs/gdb.debuginfod/fetch_src_and_symbols/fetch_src_and_symbols...

  This GDB supports auto-downloading debuginfo from the following URLs:
    <http://localhost:123>
  Enable debuginfod for this session? (y or [n])
~~~

~~~
  (gdb) with confirm off -- file testsuite/outputs/gdb.debuginfod/fetch_src_and_symbols/fetch_src_and_symbols
  Reading symbols from testsuite/outputs/gdb.debuginfod/fetch_src_and_symbols/fetch_src_and_symbols...

  This GDB supports auto-downloading debuginfo from the following URLs:
    <http://127.0.0.1:8000>
    <127.0.0.1:8000>
  Debuginfod has been disabled.
  To make this setting permanent, add 'set debuginfod enabled off' to .gdbinit.
  (No debugging symbols found in testsuite/outputs/gdb.debuginfod/fetch_src_and_symbols/fetch_src_and_symbols)
  (gdb)
~~~

I handled that correctly in the other tests that use test_urls, but
had forgotten to update the "notice empty URL" one.

Change-Id: I00040c83466e1494b3875574eb009c571a1504bf
---

diff --git a/gdb/testsuite/gdb.debuginfod/fetch_src_and_symbols.exp b/gdb/testsuite/gdb.debuginfod/fetch_src_and_symbols.exp
index 6da9a86faa8..bd90bcd0cfe 100644
--- a/gdb/testsuite/gdb.debuginfod/fetch_src_and_symbols.exp
+++ b/gdb/testsuite/gdb.debuginfod/fetch_src_and_symbols.exp
@@ -310,7 +310,7 @@ proc local_url { } {
     # Disable confirmation to avoid having to deal with a query.  See
     # test_urls.
     gdb_test_multiple "with confirm off -- file $binfile" "notice empty URL" {
-	-re ".*Enable debuginfod.*" {
+	-re -wrap "This GDB supports auto-downloading.*" {
 	    fail $gdb_test_name
 	}
 	-re -wrap "" {