From: Neil Roberts <neil@linux.intel.com>
Date: Wed, 26 Nov 2014 17:15:01 +0000 (+0000)
Subject: glsl: Disallow float literals with the 'f' suffix but no point or exponent
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=9d8aa886938c7476a911f8cf8051d87d76755394;p=mesa.git

glsl: Disallow float literals with the 'f' suffix but no point or exponent

According to the GLSL spec float literals like ‘1f’ shouldn't be allowed
without adding a decimal point or an exponent. Apparently the AMD driver also
disallows this so it seems unlikely that anything would be relying on it.

Reviewed-by: Matt Turner <mattst88@gmail.com>
---

diff --git a/src/glsl/glsl_lexer.ll b/src/glsl/glsl_lexer.ll
index ad6d32f9bc0..419a07b1daf 100644
--- a/src/glsl/glsl_lexer.ll
+++ b/src/glsl/glsl_lexer.ll
@@ -466,10 +466,6 @@ layout		{
 			    yylval->real = _mesa_strtof(yytext, NULL);
 			    return FLOATCONSTANT;
 			}
-[0-9]+[fF]		{
-			    yylval->real = _mesa_strtof(yytext, NULL);
-			    return FLOATCONSTANT;
-			}
 
 true			{
 			    yylval->n = 1;