From: Florent Kermarrec <florent@enjoy-digital.fr>
Date: Fri, 6 Feb 2015 15:58:05 +0000 (+0100)
Subject: icmp: able to ping board :)
X-Git-Tag: 24jan2021_ls180~2604^2~67
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=9dc582ac8f9ba55a04b29acdabab289fbfd1d1b5;p=litex.git

icmp: able to ping board :)
---

diff --git a/liteeth/core/icmp/__init__.py b/liteeth/core/icmp/__init__.py
index 8d65583b..2af10c89 100644
--- a/liteeth/core/icmp/__init__.py
+++ b/liteeth/core/icmp/__init__.py
@@ -77,8 +77,7 @@ class LiteEthICMPRX(Module):
 		valid = Signal()
 		self.comb += valid.eq(
 			sink.stb &
-			(self.sink.protocol == icmp_protocol) &
-			(self.sink.ip_address == ip_address)
+			(self.sink.protocol == icmp_protocol)
 		)
 		fsm.act("CHECK",
 			If(valid,
@@ -108,7 +107,7 @@ class LiteEthICMPRX(Module):
 		)
 		fsm.act("DROP",
 			sink.ack.eq(1),
-			If(source.stb & source.eop & source.ack,
+			If(sink.stb & sink.eop & sink.ack,
 				NextState("IDLE")
 			)
 		)
@@ -118,7 +117,7 @@ class LiteEthICMPEcho(Module):
 		self.sink = Sink(eth_icmp_user_description(8))
 		self.source = Source(eth_icmp_user_description(8))
 		###
-		self.submodules.fifo = SyncFIFO(eth_icmp_user_description(8), 1024)
+		self.submodules.fifo = SyncFIFO(eth_icmp_user_description(8), 512, buffered=True)
 		self.comb += [
 			Record.connect(self.sink, self.fifo.sink),
 			Record.connect(self.fifo.source, self.source),
diff --git a/liteeth/core/ip/__init__.py b/liteeth/core/ip/__init__.py
index c22069be..a03b0984 100644
--- a/liteeth/core/ip/__init__.py
+++ b/liteeth/core/ip/__init__.py
@@ -159,7 +159,7 @@ class LiteEthIPRX(Module):
 			source.eop.eq(sink.eop),
 			source.length.eq(sink.total_length - (sink.ihl*4)),
 			source.protocol.eq(sink.protocol),
-			source.ip_address.eq(sink.target_ip),
+			source.ip_address.eq(sink.sender_ip),
 			source.data.eq(sink.data),
 			source.error.eq(sink.error)
 		]
diff --git a/liteeth/core/udp/__init__.py b/liteeth/core/udp/__init__.py
index 59ea5cfd..f017b5e6 100644
--- a/liteeth/core/udp/__init__.py
+++ b/liteeth/core/udp/__init__.py
@@ -77,8 +77,7 @@ class LiteEthUDPRX(Module):
 		valid = Signal()
 		self.comb += valid.eq(
 			sink.stb &
-			(self.sink.protocol == udp_protocol) &
-			(self.sink.ip_address == ip_address)
+			(self.sink.protocol == udp_protocol)
 		)
 
 		fsm.act("CHECK",
@@ -107,7 +106,7 @@ class LiteEthUDPRX(Module):
 		)
 		fsm.act("DROP",
 			sink.ack.eq(1),
-			If(source.stb & source.eop & source.ack,
+			If(sink.stb & sink.eop & sink.ack,
 				NextState("IDLE")
 			)
 		)
diff --git a/targets/udpip.py b/targets/udpip.py
index 98a92484..b0307a38 100644
--- a/targets/udpip.py
+++ b/targets/udpip.py
@@ -193,6 +193,8 @@ class UDPIPSoCDevel(UDPIPSoC, AutoCSR):
 	def __init__(self, platform):
 		UDPIPSoC.__init__(self, platform)
 
+		self.udpip_core_icmp_rx_fsm_state = Signal(4)
+		self.udpip_core_icmp_tx_fsm_state = Signal(4)
 		self.udpip_core_udp_rx_fsm_state = Signal(4)
 		self.udpip_core_udp_tx_fsm_state = Signal(4)
 		self.udpip_core_ip_rx_fsm_state = Signal(4)
@@ -214,6 +216,26 @@ class UDPIPSoCDevel(UDPIPSoC, AutoCSR):
 			self.udpip_core.mac.core.source.ack,
 			self.udpip_core.mac.core.source.data,
 
+			self.udpip_core.icmp.echo.sink.stb,
+			self.udpip_core.icmp.echo.sink.sop,
+			self.udpip_core.icmp.echo.sink.eop,
+			self.udpip_core.icmp.echo.sink.ack,
+			self.udpip_core.icmp.echo.sink.data,
+
+			self.udpip_core.icmp.echo.source.stb,
+			self.udpip_core.icmp.echo.source.sop,
+			self.udpip_core.icmp.echo.source.eop,
+			self.udpip_core.icmp.echo.source.ack,
+			self.udpip_core.icmp.echo.source.data,
+
+			self.udpip_core.ip.crossbar.master.sink.stb,
+			self.udpip_core.ip.crossbar.master.sink.sop,
+			self.udpip_core.ip.crossbar.master.sink.eop,
+			self.udpip_core.ip.crossbar.master.sink.ack,
+			self.udpip_core.ip.crossbar.master.sink.data,
+			self.udpip_core.ip.crossbar.master.sink.ip_address,
+			self.udpip_core.ip.crossbar.master.sink.protocol,
+
 			self.ethphy.sink.stb,
 			self.ethphy.sink.sop,
 			self.ethphy.sink.eop,
@@ -226,6 +248,8 @@ class UDPIPSoCDevel(UDPIPSoC, AutoCSR):
 			self.ethphy.source.ack,
 			self.ethphy.source.data,
 
+			self.udpip_core_icmp_rx_fsm_state,
+			self.udpip_core_icmp_tx_fsm_state,
 			self.udpip_core_udp_rx_fsm_state,
 			self.udpip_core_udp_tx_fsm_state,
 			self.udpip_core_ip_rx_fsm_state,
@@ -233,7 +257,6 @@ class UDPIPSoCDevel(UDPIPSoC, AutoCSR):
 			self.udpip_core_arp_rx_fsm_state,
 			self.udpip_core_arp_tx_fsm_state,
 			self.udpip_core_arp_table_fsm_state,
-
 		)
 
 		self.submodules.la = LiteScopeLA(debug, 2048)
@@ -243,6 +266,8 @@ class UDPIPSoCDevel(UDPIPSoC, AutoCSR):
 	def do_finalize(self):
 		UDPIPSoC.do_finalize(self)
 		self.comb += [
+			self.udpip_core_icmp_rx_fsm_state.eq(self.udpip_core.icmp.rx.fsm.state),
+			self.udpip_core_icmp_tx_fsm_state.eq(self.udpip_core.icmp.tx.fsm.state),
 			self.udpip_core_udp_rx_fsm_state.eq(self.udpip_core.udp.rx.fsm.state),
 			self.udpip_core_udp_tx_fsm_state.eq(self.udpip_core.udp.tx.fsm.state),
 			self.udpip_core_ip_rx_fsm_state.eq(self.udpip_core.ip.rx.fsm.state),
diff --git a/test/test_udpip.py b/test/test_udpip.py
index eb980c99..2d625c89 100644
--- a/test/test_udpip.py
+++ b/test/test_udpip.py
@@ -23,16 +23,22 @@ regs.bist_generator_ip_address.write(convert_ip("192.168.1.10"))
 regs.bist_generator_length.write(64)
 
 conditions = {}
+#conditions = {
+#	"udpipsocdevel_mac_tx_cdc_sink_stb"	: 1
+#}
 conditions = {
-	"udpipsocdevel_mac_tx_cdc_sink_stb"	: 1
+	"udpipsocdevel_icmp_echo_sink_sink_stb"	: 1
+}
+conditions = {
+	"udpip_core_ip_rx_fsm_state"	: 1
 }
 la.configure_term(port=0, cond=conditions)
 la.configure_sum("term")
 # Run Logic Analyzer
 la.run(offset=64, length=1024)
 
-for i in range(64):
-	regs.bist_generator_start.write(1)
+#for i in range(64):
+#	regs.bist_generator_start.write(1)
 
 while not la.done():
 	pass