From: Gary Benson <gbenson@redhat.com>
Date: Thu, 12 Nov 2020 15:05:22 +0000 (+0000)
Subject: Fix gdb.threads/tls-so_extern.exp with Clang
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=9e74f0aef6a73dba185161558cebace2ed9a54e5;p=binutils-gdb.git

Fix gdb.threads/tls-so_extern.exp with Clang

Clang fails to compile gdb.threads/tls-so_extern_main.c, giving the
following error:

  /gdbtest/src/gdb/testsuite/gdb.threads/tls-so_extern_main.c:28:1:
    warning: non-void function does not return a value [-Wreturn-type]

This commit adds a return statement to the offending function.

gdb/testsuite/ChangeLog:

	* gdb.threads/tls-so_extern_main.c (tls_ptr): Add missing return
	statement.
---

diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 855ceaaa3db..ecac8bbe052 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2020-11-12  Gary Benson <gbenson@redhat.com>
+
+	* gdb.threads/tls-so_extern_main.c (tls_ptr): Add missing return
+	statement.
+
 2020-11-11  Simon Marchi  <simon.marchi@efficios.com>
 
 	* gdb.base/continue-after-aborted-step-over.exp: Add "breakpoint
diff --git a/gdb/testsuite/gdb.threads/tls-so_extern_main.c b/gdb/testsuite/gdb.threads/tls-so_extern_main.c
index c326451d3c4..8ad857ceb24 100644
--- a/gdb/testsuite/gdb.threads/tls-so_extern_main.c
+++ b/gdb/testsuite/gdb.threads/tls-so_extern_main.c
@@ -25,6 +25,8 @@ tls_ptr (void *p)
 {
    so_extern = &so_extern;
    so_extern2 = &so_extern2; /* break here to check result */
+
+   return NULL;
 }
 
 int