From: Richard Sandiford <richard.sandiford@linaro.org>
Date: Sun, 7 Jan 2018 03:59:54 +0000 (+0000)
Subject: re PR middle-end/83699 (Many 64-bit SPARC gcc.dg/vect tests FAIL)
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=9ea52d27eca0c56c88a3941b413ef56950d9f5c3;p=gcc.git

re PR middle-end/83699 (Many 64-bit SPARC gcc.dg/vect tests FAIL)

	PR rtl-optimization/83699
	* expmed.c (extract_bit_field_1): Restrict the vector usage of
	extract_bit_field_as_subreg to cases in which the extracted
	value is also a vector.

From-SVN: r256318
---

diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index 767d7458bb3..bade4b29349 100644
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,5 +1,10 @@
 2018-01-06  Richard Sandiford  <richard.sandiford@linaro.org>
 
+	PR rtl-optimization/83699
+	* expmed.c (extract_bit_field_1): Restrict the vector usage of
+	extract_bit_field_as_subreg to cases in which the extracted
+	value is also a vector.
+
 	* lra-constraints.c (process_alt_operands): Test for the equivalence
 	substitutions when detecting a possible reload cycle.
 
diff --git a/gcc/expmed.c b/gcc/expmed.c
index d88ea3508e4..808b067c670 100644
--- a/gcc/expmed.c
+++ b/gcc/expmed.c
@@ -1738,16 +1738,10 @@ extract_bit_field_1 (rtx str_rtx, poly_uint64 bitsize, poly_uint64 bitnum,
 	      return target;
 	    }
 	}
-      /* Using subregs is useful if we're extracting the least-significant
-	 vector element, or if we're extracting one register vector from
-	 a multi-register vector.  extract_bit_field_as_subreg checks
-	 for valid bitsize and bitnum, so we don't need to do that here.
-
-	 The mode check makes sure that we're extracting either
-	 a single element or a subvector with the same element type.
-	 If the modes aren't such a natural fit, fall through and
-	 bitcast to integers first.  */
-      if (GET_MODE_INNER (mode) == innermode)
+      /* Using subregs is useful if we're extracting one register vector
+	 from a multi-register vector.  extract_bit_field_as_subreg checks
+	 for valid bitsize and bitnum, so we don't need to do that here.  */
+      if (VECTOR_MODE_P (mode))
 	{
 	  rtx sub = extract_bit_field_as_subreg (mode, op0, bitsize, bitnum);
 	  if (sub)