From: Tom de Vries <tdevries@suse.de>
Date: Thu, 30 Sep 2021 17:07:48 +0000 (+0200)
Subject: [gdb/testsuite] Check compilation result in gdb.dwarf2/dw2-opt-structptr.exp
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=9ebd2909664f80aa669bf3d904a4c809691e3198;p=binutils-gdb.git

[gdb/testsuite] Check compilation result in gdb.dwarf2/dw2-opt-structptr.exp

When running test-case gdb.dwarf2/dw2-opt-structptr.exp with target board
unix/-bad, I get:
...
gdb compile failed, gcc: error: unrecognized command line option '-bad'
UNTESTED: gdb.dwarf2/dw2-opt-structptr.exp: dw2-opt-structptr.exp
UNTESTED: gdb.dwarf2/dw2-opt-structptr.exp: failed to compile
ERROR: (dw2-opt-structptr) No such file or directory
UNRESOLVED: gdb.dwarf2/dw2-opt-structptr.exp: console: set print object on
...

Merge the two UNTESTEDs.

Fix the UNRESOLVED by checking result of compilation.

Tested on x86_64-linux.
---

diff --git a/gdb/testsuite/gdb.dwarf2/dw2-opt-structptr.exp b/gdb/testsuite/gdb.dwarf2/dw2-opt-structptr.exp
index 6883b086b89..82a53a3d2ea 100644
--- a/gdb/testsuite/gdb.dwarf2/dw2-opt-structptr.exp
+++ b/gdb/testsuite/gdb.dwarf2/dw2-opt-structptr.exp
@@ -123,8 +123,7 @@ proc build_test_program {} {
     }
     
     set sources "$srcfile $asm_file"
-    if {[build_executable $testfile.exp $testfile $sources {nodebug}]} { 
-	untested "failed to compile"
+    if {[build_executable "failed to compile" $testfile $sources {nodebug}]} {
 	return -1
     }
 }
@@ -245,6 +244,9 @@ proc do_mi_test {} {
     }
 }
 
-build_test_program
+if { [build_test_program] == -1 } {
+    return -1
+}
+
 do_console_test
 do_mi_test