From: Yann E. MORIN Date: Tue, 2 Jul 2019 20:12:50 +0000 (+0200) Subject: core/pkg-infra: really build all dependencies of foo with foo-depends X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=9ee584c0ddf17b8d6771b8c80c8395793d7e182a;p=buildroot.git core/pkg-infra: really build all dependencies of foo with foo-depends Currently, foo-depends only builds build dependencies. This means that download and extract dependencies are not built. First, but a minor point, this is inconsistent with foo-show-depends, which does display all dependencies: $ make host-gzip-show-depends host-skeleton host-tar $ make host-gzip-depends # Only host-skeleton is built and installed Second, and more important, it makes it more difficult to preapre a debug build, like so: $ make foo-depends $ tar cf output.tar output $ make foo # bummer, broken # edit foo.mk to try and fix it $ rm -rf output; tar xf output.tar # rince and repeat Change foo-depends so that it really builds all the dependencies for foo, bringing it on-par with foo-show-depends. Signed-off-by: Yann E. MORIN Cc: Thomas Petazzoni Signed-off-by: Arnout Vandecappelle (Essensium/Mind) --- diff --git a/package/pkg-generic.mk b/package/pkg-generic.mk index b00967c648..9620dec524 100644 --- a/package/pkg-generic.mk +++ b/package/pkg-generic.mk @@ -801,7 +801,7 @@ $(1)-extract: $$($(2)_TARGET_EXTRACT) $$($(2)_TARGET_EXTRACT): $$($(2)_TARGET_SOURCE) $$($(2)_TARGET_EXTRACT): | $$($(2)_FINAL_EXTRACT_DEPENDENCIES) -$(1)-depends: $$($(2)_FINAL_DEPENDENCIES) +$(1)-depends: $$($(2)_FINAL_ALL_DEPENDENCIES) $(1)-source: $$($(2)_TARGET_SOURCE) $$($(2)_TARGET_SOURCE): | $$($(2)_FINAL_DOWNLOAD_DEPENDENCIES)