From: Luke Kenneth Casson Leighton <lkcl@lkcl.net>
Date: Sun, 21 Apr 2019 07:26:07 +0000 (+0100)
Subject: comment where PermissionValidator needed
X-Git-Tag: div_pipeline~2208
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=9f42aff3b589e9a50d3a33e5da1a1be87042be7b;p=soc.git

comment where PermissionValidator needed
---

diff --git a/TLB/src/ariane/mmu.py b/TLB/src/ariane/mmu.py
index 0cc04dbb..a5c27a9e 100644
--- a/TLB/src/ariane/mmu.py
+++ b/TLB/src/ariane/mmu.py
@@ -231,10 +231,12 @@ class MMU:
         m.d.comb += icache_areq_o.fetch_exception.eq(0)
         # Check whether we are allowed to access this memory region
         # from a fetch perspective
+
+        # XXX TODO: use PermissionValidator instead [we like modules]
         m.d.comb += iaccess_err.eq(icache_areq_i.fetch_req & \
                                    (((priv_lvl_i == PRIV_LVL_U) & \
                                       ~itlb_content.u) | \
-                                   ((priv_lvl_i == :PRIV_LVL_S) & \
+                                   ((priv_lvl_i == PRIV_LVL_S) & \
                                     itlb_content.u)))
 
         # MMU enabled: address from TLB, request delayed until hit.