From: Jan Kratochvil Date: Wed, 6 Apr 2011 00:08:12 +0000 (+0000) Subject: gdb/ X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=9f743ef6ffbfd6cb5c135a7dfef27b637b894084;p=binutils-gdb.git gdb/ Fix crash regression on systems featuring .gdb_index. * objfiles.c (free_objfile): Move the forget_cached_source_info_for_objfile call earlier. Comment it. Extend the comment for objfile_free_data. --- diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 777947dc9bc..848a0728f68 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,10 @@ +2011-04-06 Jan Kratochvil + + Fix crash regression on systems featuring .gdb_index. + * objfiles.c (free_objfile): Move the + forget_cached_source_info_for_objfile call earlier. Comment it. + Extend the comment for objfile_free_data. + 2011-04-06 Jan Kratochvil Fix regression of displaying the debug format. diff --git a/gdb/objfiles.c b/gdb/objfiles.c index 1664e429f0a..db01f424588 100644 --- a/gdb/objfiles.c +++ b/gdb/objfiles.c @@ -583,6 +583,10 @@ free_objfile (struct objfile *objfile) lists. */ preserve_values (objfile); + /* It still may reference data modules have associated with the objfile and + the symbol file data. */ + forget_cached_source_info_for_objfile (objfile); + /* First do any symbol file specific actions required when we are finished with a particular symbol file. Note that if the objfile is using reusable symbol information (via mmalloc) then each of @@ -595,7 +599,8 @@ free_objfile (struct objfile *objfile) (*objfile->sf->sym_finish) (objfile); } - /* Discard any data modules have associated with the objfile. */ + /* Discard any data modules have associated with the objfile. The function + still may reference objfile->obfd. */ objfile_free_data (objfile); gdb_bfd_unref (objfile->obfd); @@ -637,8 +642,6 @@ free_objfile (struct objfile *objfile) clear_current_source_symtab_and_line (); } - forget_cached_source_info_for_objfile (objfile); - /* The last thing we do is free the objfile struct itself. */ xfree (objfile->name);