From: Chia-I Wu <olvaffe@gmail.com>
Date: Tue, 7 May 2019 17:56:40 +0000 (-0700)
Subject: virgl: do not skip readback because of explicit flush
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=9f8521882a62e9441afb7fbb55329306d50fef8d;p=mesa.git

virgl: do not skip readback because of explicit flush

Both apps and we (see virgl_buffer_transfer_flush_region) might
flush regions that are unmodified.  We have to read back for those
flushes.

Signed-off-by: Chia-I Wu <olvaffe@gmail.com>
Reviewed-by: Alexandros Frantzis <alexandros.frantzis@collabora.com>
Reviewed-by: Gurchetan Singh <gurchetansingh@chromium.org>
---

diff --git a/src/gallium/drivers/virgl/virgl_resource.c b/src/gallium/drivers/virgl/virgl_resource.c
index bd0a633e471..9cbff8d8d54 100644
--- a/src/gallium/drivers/virgl/virgl_resource.c
+++ b/src/gallium/drivers/virgl/virgl_resource.c
@@ -56,9 +56,6 @@ bool virgl_res_needs_readback(struct virgl_context *vctx,
       readback = false;
    else if (usage & PIPE_TRANSFER_DISCARD_RANGE)
       readback = false;
-   else if ((usage & (PIPE_TRANSFER_WRITE | PIPE_TRANSFER_FLUSH_EXPLICIT)) ==
-            (PIPE_TRANSFER_WRITE | PIPE_TRANSFER_FLUSH_EXPLICIT))
-      readback = false;
    return readback;
 }