From: Jacob Lifshay <programmerjake@gmail.com>
Date: Sat, 19 Jun 2021 00:09:56 +0000 (-0700)
Subject: remove note to convert to sin_cos_tau instead sin_cos_pi
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=HEAD;hp=a43a29ccd5824b9b6dcb45baa3ccb3f8c5ea72e1;p=vector-math.git

remove note to convert to sin_cos_tau instead sin_cos_pi

In the process of converting the code, I discovered that
it would not remove any operations from sin_cos and that sin_cos_pi
would require an additional multiplication to implement, since what
the software implementation would really need instead of sin_cos_tau
would be for the input to be expressed as a integer number of right-
angles (how many multiples of 90 degrees is the input angle).
---

diff --git a/src/algorithms/trig_pi.rs b/src/algorithms/trig_pi.rs
index 834fd96..5be0ad6 100644
--- a/src/algorithms/trig_pi.rs
+++ b/src/algorithms/trig_pi.rs
@@ -3,9 +3,6 @@ use crate::{
     traits::{Compare, Context, ConvertFrom, ConvertTo, Float, Make, Select},
 };
 
-// TODO: change `sin`/`cos`/`sin_pi`/`cos_pi` implementations to be
-// in terms of `sin_cos_tau` aka. `(sin(2 * pi * x), cos(2 * pi * x))`
-
 mod consts {
     #![allow(clippy::excessive_precision)]
     #![allow(dead_code)]