From: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Date: Tue, 14 Apr 2020 13:57:08 +0000 (+0200)
Subject: ci: Don't call renderdoc's ReplayController.Shutdown()
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=a04672a105239b230b0e880d63cee6621a10f10c;p=mesa.git

ci: Don't call renderdoc's ReplayController.Shutdown()

If we do, Renderdoc will call eglDestroyContext twice, causing crashes
within Mesa.

Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Acked-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Reviewed-by: Eric Anholt <eric@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5433>
---

diff --git a/.gitlab-ci/tracie/renderdoc_dump_images.py b/.gitlab-ci/tracie/renderdoc_dump_images.py
index 93e24b9ca25..a89b5fda794 100755
--- a/.gitlab-ci/tracie/renderdoc_dump_images.py
+++ b/.gitlab-ci/tracie/renderdoc_dump_images.py
@@ -112,7 +112,6 @@ def renderdoc_dump_images(filename, eventIds, outputDir):
    for eventId in eventIds:
       dumpImage(controller, eventId, outputDir, tracefile)
 
-   controller.Shutdown()
    cap.Shutdown()
 
    rd.ShutdownReplay()