From: José Fonseca Date: Sun, 9 May 2010 21:31:18 +0000 (+0100) Subject: gallivm: Use a more compact approach for lp_build_broadcast_scalar(). X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=a09e46c72461183c879d8472b44fe740ecc79b9f;p=mesa.git gallivm: Use a more compact approach for lp_build_broadcast_scalar(). It produces exactly the same machine code, but it cuts 5% of the number of instructions generated for a typical shader. Also, preserve the scalar when length is 1. --- diff --git a/src/gallium/auxiliary/gallivm/lp_bld_swizzle.c b/src/gallium/auxiliary/gallivm/lp_bld_swizzle.c index 6a3c8f3f3a4..f095a39cf52 100644 --- a/src/gallium/auxiliary/gallivm/lp_bld_swizzle.c +++ b/src/gallium/auxiliary/gallivm/lp_bld_swizzle.c @@ -68,18 +68,20 @@ lp_build_broadcast_scalar(struct lp_build_context *bld, LLVMValueRef scalar) { const struct lp_type type = bld->type; - LLVMValueRef res; - unsigned i; assert(lp_check_elem_type(type, LLVMTypeOf(scalar))); - res = bld->undef; - for(i = 0; i < type.length; ++i) { - LLVMValueRef index = LLVMConstInt(LLVMInt32Type(), i, 0); - res = LLVMBuildInsertElement(bld->builder, res, scalar, index, ""); + if (type.length == 1) { + return scalar; + } + else { + LLVMValueRef res; + res = LLVMBuildInsertElement(bld->builder, bld->undef, scalar, + LLVMConstInt(LLVMInt32Type(), 0, 0), ""); + res = LLVMBuildShuffleVector(bld->builder, res, bld->undef, + lp_build_const_int_vec(type, 0), ""); + return res; } - - return res; }