From: Jason Ekstrand Date: Thu, 30 Aug 2018 17:50:31 +0000 (-0500) Subject: intel/nir: Lowering image loads and stores trashes all metadata X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=a0f18f214215931bfe6b27dd86c09ec5bae49103;p=mesa.git intel/nir: Lowering image loads and stores trashes all metadata This fixes the GL_ARB_fragment_shader_interlock piglit test on gen8 platforms where the lack of metadata dirtying was causing another pass to accidentally delete a much needed loop. https://bugs.freedesktop.org/show_bug.cgi?id=107745 Fixes: 37f7983bcca1 "intel/compiler: Do image load/store lowering..." Jason Ekstrand writes: Reviewed-by: Caio Marcelo de Oliveira Filho --- diff --git a/src/intel/compiler/brw_nir_lower_image_load_store.c b/src/intel/compiler/brw_nir_lower_image_load_store.c index de6f7683be4..e8083a80cb7 100644 --- a/src/intel/compiler/brw_nir_lower_image_load_store.c +++ b/src/intel/compiler/brw_nir_lower_image_load_store.c @@ -817,8 +817,8 @@ brw_nir_lower_image_load_store(nir_shader *shader, } } - nir_metadata_preserve(function->impl, nir_metadata_block_index | - nir_metadata_dominance); + if (progress) + nir_metadata_preserve(function->impl, nir_metadata_none); } return progress;