From: Tsukasa OI <research_trasio@irq.a4lg.com>
Date: Thu, 6 Oct 2022 06:36:28 +0000 (+0000)
Subject: sim/cris: Add ATTRIBUTE_PRINTF
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=a26c7ec2114d75d518cda714cc8a0ec05b745ae5;p=binutils-gdb.git

sim/cris: Add ATTRIBUTE_PRINTF

Clang generates a warning if the format string of a printf-like function is
not a literal ("-Wformat-nonliteral").  On the default configuration, it
causes a build failure (unless "--disable-werror" is specified).

To avoid warnings on the printf-like wrapper, it requires proper
__attribute__((format)) and we have ATTRIBUTE_PRINTF macro for this reason.

This commit adds ATTRIBUTE_PRINTF to a printf-like function.
---

diff --git a/sim/cris/traps.c b/sim/cris/traps.c
index 8750c4d4e3c..7b0140f1c90 100644
--- a/sim/cris/traps.c
+++ b/sim/cris/traps.c
@@ -1382,7 +1382,7 @@ make_first_thread (SIM_CPU *current_cpu)
 /* Handle unknown system calls.  Returns (if it does) the syscall
    return value.  */
 
-static USI
+static USI ATTRIBUTE_PRINTF (3, 4)
 cris_unknown_syscall (SIM_CPU *current_cpu, USI pc, char *s, ...)
 {
   SIM_DESC sd = CPU_STATE (current_cpu);