From: Brian Paul <brianp@vmware.com>
Date: Mon, 24 Apr 2017 18:58:22 +0000 (-0600)
Subject: gallium/util: reduce util_snprintf() calls in debug_flush_might_flush_cb()
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=a36a1ea80acfd28a36d89b2bfa914ab48768048d;p=mesa.git

gallium/util: reduce util_snprintf() calls in debug_flush_might_flush_cb()

We only need to construct the debug message if the mapped_sync flag is set.
This should make the function faster since the flag is usually false.

Reviewed-by: Charmaine Lee <charmainel@vmware.com>
---

diff --git a/src/gallium/auxiliary/util/u_debug_flush.c b/src/gallium/auxiliary/util/u_debug_flush.c
index fe96e09aadf..98a69b2de05 100644
--- a/src/gallium/auxiliary/util/u_debug_flush.c
+++ b/src/gallium/auxiliary/util/u_debug_flush.c
@@ -320,14 +320,15 @@ debug_flush_might_flush_cb(void *key, void *value, void *data)
    struct debug_flush_item *item =
       (struct debug_flush_item *) value;
    struct debug_flush_buf *fbuf = item->fbuf;
-   const char *reason = (const char *) data;
-   char message[80];
-
-   util_snprintf(message, sizeof(message),
-                 "%s referenced mapped buffer detected.", reason);
 
    mtx_lock(&fbuf->mutex);
    if (fbuf->mapped_sync) {
+      const char *reason = (const char *) data;
+      char message[80];
+
+      util_snprintf(message, sizeof(message),
+                    "%s referenced mapped buffer detected.", reason);
+
       debug_flush_alert(message, reason, 3, item->bt_depth, TRUE, TRUE, NULL);
       debug_flush_alert(NULL, "Map", 0, fbuf->bt_depth, TRUE, FALSE,
                         fbuf->map_frame);