From: Kenneth Graunke Date: Mon, 9 Jan 2012 00:27:36 +0000 (-0800) Subject: i965: Fix zeroing of unused attributes in 3DSTATE_SBE. X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=a48cc138a8b7c55f8d12796677e081c2b2085f48;p=mesa.git i965: Fix zeroing of unused attributes in 3DSTATE_SBE. This brings the code in sync with gen6_sf_state.c; presumably the mistake was a botched rebase on initial Ivybridge bring-up patches. Found by diffing batch buffer dumps and noticing the random values. Thanks to Eric for catching the obvious mistake. NOTE: This is a candidate for the 7.11 branch. Signed-off-by: Kenneth Graunke Reviewed-by: Eric Anholt --- diff --git a/src/mesa/drivers/dri/i965/gen7_sf_state.c b/src/mesa/drivers/dri/i965/gen7_sf_state.c index 90853181009..c4cacf095ed 100644 --- a/src/mesa/drivers/dri/i965/gen7_sf_state.c +++ b/src/mesa/drivers/dri/i965/gen7_sf_state.c @@ -111,8 +111,8 @@ upload_sbe_state(struct brw_context *brw) ctx->VertexProgram._TwoSideEnabled); } - for (; attr < FRAG_ATTRIB_MAX; attr++) - attr_overrides[input_index++] = 0; + for (; input_index < FRAG_ATTRIB_MAX; input_index++) + attr_overrides[input_index] = 0; BEGIN_BATCH(14); OUT_BATCH(_3DSTATE_SBE << 16 | (14 - 2));