From: Eric Anholt Date: Mon, 23 Dec 2013 09:56:26 +0000 (-0800) Subject: i965: Fix incorrect bounds tracking for blit readpixels's GPU access. X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=a4b222ac135c28a3bc95cc0d9fd29378540c8def;p=mesa.git i965: Fix incorrect bounds tracking for blit readpixels's GPU access. While incorrect, it probably wouldn't affect anyone ever: You'd have to do an appropriately-formatted readpixels into a PBO, then overwrite the tail end of the updated area of the PBO with glBufferSubData(), and you wouldn't get appropriate synchronization. Reviewed-by: Kenneth Graunke Reviewed-by: Ian Romanick Reviewed-by: Anuj Phogat --- diff --git a/src/mesa/drivers/dri/i965/intel_pixel_read.c b/src/mesa/drivers/dri/i965/intel_pixel_read.c index 08cb7624bb1..0f6d2aaa387 100644 --- a/src/mesa/drivers/dri/i965/intel_pixel_read.c +++ b/src/mesa/drivers/dri/i965/intel_pixel_read.c @@ -127,8 +127,7 @@ do_blit_readpixels(struct gl_context * ctx, brw->front_buffer_dirty = dirty; dst_buffer = intel_bufferobj_buffer(brw, dst, - dst_offset, width * height * - irb->mt->cpp); + dst_offset, height * dst_stride); struct intel_mipmap_tree *pbo_mt = intel_miptree_create_for_bo(brw,